-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34967/#review86343
-----------------------------------------------------------

Ship it!


I understand it may be too much for this scope but we should really address 
AURORA-1193 to improve user experience for all status update reasons, not just 
OOM. Giving it a ship it as a stop gap solution.


src/main/java/org/apache/aurora/scheduler/UserTaskLauncher.java
<https://reviews.apache.org/r/34967/#comment138300>

    Remove MEMORY_LIMIT_EXCEEDED as it's no longer referenced.



src/test/java/org/apache/aurora/scheduler/UserTaskLauncherTest.java
<https://reviews.apache.org/r/34967/#comment138397>

    any particular reason for this change?


- Maxim Khutornenko


On June 3, 2015, 1:11 a.m., Zameer Manji wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34967/
> -----------------------------------------------------------
> 
> (Updated June 3, 2015, 1:11 a.m.)
> 
> 
> Review request for Aurora and Maxim Khutornenko.
> 
> 
> Bugs: AURORA-1341
>     https://issues.apache.org/jira/browse/AURORA-1341
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Use TaskStatus Reason to set memory limit message instead of checking the 
> contents of the message field. Future versions of Mesos can change the 
> diagnostic information in the message field causing Aurora to display no 
> information when a task fails.
> 
> 
> Diffs
> -----
> 
>   src/main/java/org/apache/aurora/scheduler/UserTaskLauncher.java 
> 5af691d0ac959cf4b5d01752daf996803e91ed16 
>   src/test/java/org/apache/aurora/scheduler/UserTaskLauncherTest.java 
> fe2fc954350b42487151fc820ebad22a41aeb039 
> 
> Diff: https://reviews.apache.org/r/34967/diff/
> 
> 
> Testing
> -------
> 
> ./gradlew test -Pq
> 
> 
> Thanks,
> 
> Zameer Manji
> 
>

Reply via email to