> On June 16, 2015, 10:25 p.m., Brian Wickman wrote: > > src/test/python/apache/thermos/observer/test_task_observer.py, lines 37-38 > > <https://reviews.apache.org/r/35527/diff/2/?file=986119#file986119line37> > > > > while ugly, should probably change pass to time.sleep(0.01) so that > > MainThread yields to the observer thread to make forward progress.
The busy wait loop relying on the mock_call count works just fine here producing the same 0.29sec run as the one with time.sleep(0.01). Is there a particular concern you have in mind? - Maxim ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35527/#review88144 ----------------------------------------------------------- On June 16, 2015, 10:18 p.m., Maxim Khutornenko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/35527/ > ----------------------------------------------------------- > > (Updated June 16, 2015, 10:18 p.m.) > > > Review request for Aurora, Joshua Cohen and Brian Wickman. > > > Bugs: AURORA-1351 > https://issues.apache.org/jira/browse/AURORA-1351 > > > Repository: aurora > > > Description > ------- > > Making observer polling interval configurable. > > > Diffs > ----- > > src/main/python/apache/aurora/tools/__init__.py PRE-CREATION > src/main/python/apache/aurora/tools/thermos_observer.py > 4b534d3b0ccb78ddbe2f8d66eba0c2560ea48474 > src/main/python/apache/thermos/observer/task_observer.py > b9a37de0f6260dc8c0a6ba92119c57e16f29d82c > src/test/python/apache/aurora/BUILD > 0701440ae47034c580b5baae40e5f6feec4bb4fd > src/test/python/apache/aurora/tools/BUILD PRE-CREATION > src/test/python/apache/aurora/tools/test_thermos_observer_entry_point.py > PRE-CREATION > src/test/python/apache/thermos/observer/test_task_observer.py PRE-CREATION > > Diff: https://reviews.apache.org/r/35527/diff/ > > > Testing > ------- > > ./pants --test.pytest --no-fast src/test/python:: > > > Thanks, > > Maxim Khutornenko > >