> On June 18, 2015, 4:42 p.m., Bill Farner wrote:
> > src/test/java/org/apache/aurora/scheduler/mesos/MesosSchedulerImplTest.java,
> >  line 314
> > <https://reviews.apache.org/r/35587/diff/1/?file=986660#file986660line314>
> >
> >     What's being tested here?  If i'm reading correctly, this test case 
> > would pass before the patch.
> 
> Maxim Khutornenko wrote:
>     This is mostly for test coverage similarly to the 
> testOfferFirstAcceptsFineLogging above. Asserting a message would require 
> replacing current anonymous logger with a mock and deeper refactoring. Do you 
> think it's worth it here?

You could pass a mock/stub `Logger` and expect the behavior (if you do, please 
be vague with expectations to avoid coupling to log message strings, etc).  If 
that's not to your liking, you could punt.


- Bill


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35587/#review88388
-----------------------------------------------------------


On June 18, 2015, 5:04 p.m., Maxim Khutornenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35587/
> -----------------------------------------------------------
> 
> (Updated June 18, 2015, 5:04 p.m.)
> 
> 
> Review request for Aurora and Bill Farner.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Suppress task reconciliation status update logging.
> 
> 
> Diffs
> -----
> 
>   src/main/java/org/apache/aurora/scheduler/mesos/MesosSchedulerImpl.java 
> f233d5a181bb1f43fbbfe657dbda2cf975aa6895 
>   src/test/java/org/apache/aurora/scheduler/mesos/MesosSchedulerImplTest.java 
> f0f9ac392973a276028aee3e06517a6e6d960bb6 
> 
> Diff: https://reviews.apache.org/r/35587/diff/
> 
> 
> Testing
> -------
> 
> ./gradlew -Pq build
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>

Reply via email to