-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35627/#review88440
-----------------------------------------------------------

Ship it!



src/main/java/org/apache/aurora/auth/UnsecureAuthModule.java (line 40)
<https://reviews.apache.org/r/35627/#comment140957>

    Given how non-obvious this was, it deserves a comment to indicate why this 
is necessary.


- Bill Farner


On June 18, 2015, 9:40 p.m., Kevin Sweeney wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35627/
> -----------------------------------------------------------
> 
> (Updated June 18, 2015, 9:40 p.m.)
> 
> 
> Review request for Aurora and Bill Farner.
> 
> 
> Bugs: AURORA-1352
>     https://issues.apache.org/jira/browse/AURORA-1352
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Explicitly bind SessionContext.
> 
> Discussion on bugs like this and a potential solution (enabling 
> `requireExplicitBindings`) are here: 
> https://github.com/google/guice/issues/740
> 
> 
> Diffs
> -----
> 
>   src/main/java/org/apache/aurora/auth/UnsecureAuthModule.java 
> c89ff0fed60af04f04177e9cdfba6a24b62c2e97 
>   src/main/java/org/apache/aurora/auth/UnsecureSessionContext.java 
> 57132ac480702c93934ada198475203b0648ad6a 
>   src/test/java/org/apache/aurora/auth/UnsecureSessionContextTest.java 
> 0a842cb9cdd266690b2d3103126e831fe07b1735 
>   src/test/sh/org/apache/aurora/e2e/test_kerberos_end_to_end.sh 
> 4d6043a402a761fe44239e33b83c1c8872fe7068 
> 
> Diff: https://reviews.apache.org/r/35627/diff/
> 
> 
> Testing
> -------
> 
> Ran kerberos e2e test.
> 
> 
> Thanks,
> 
> Kevin Sweeney
> 
>

Reply via email to