-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35498/#review88552
-----------------------------------------------------------


Loogs great overall! Just a few nits/suggestions.


src/main/java/org/apache/aurora/scheduler/sla/MetricCalculator.java (line 68)
<https://reviews.apache.org/r/35498/#comment141136>

    s/metrices/metrics



src/main/java/org/apache/aurora/scheduler/sla/MetricCalculator.java (line 73)
<https://reviews.apache.org/r/35498/#comment141138>

    This should fit to the previous line. Same below.



src/main/java/org/apache/aurora/scheduler/sla/MetricCalculator.java (line 137)
<https://reviews.apache.org/r/35498/#comment141139>

    requireNonNull



src/main/java/org/apache/aurora/scheduler/sla/MetricCalculator.java (line 207)
<https://reviews.apache.org/r/35498/#comment141142>

    Move this to const and reference from tests?



src/main/java/org/apache/aurora/scheduler/sla/SlaModule.java (line 65)
<https://reviews.apache.org/r/35498/#comment141141>

    Since it backs enum, you may want to add something like: 
    
    "... Available metric categories:" + 
Joiner.on(",").join(MetricCategory.values())


- Maxim Khutornenko


On June 19, 2015, 3:23 p.m., Stephan Erb wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35498/
> -----------------------------------------------------------
> 
> (Updated June 19, 2015, 3:23 p.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Maxim Khutornenko.
> 
> 
> Bugs: AURORA-1350
>     https://issues.apache.org/jira/browse/AURORA-1350
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Compute SLA stats for non-prod jobs
> 
> This is a first iteration closely following the design proposal of Maxim as 
> posted on the mailinglist. Feedback welcome.
> 
> 
> Diffs
> -----
> 
>   src/main/java/org/apache/aurora/scheduler/sla/MetricCalculator.java 
> 82f36d5ca15df18bdc8ebbbd868d3394db38e603 
>   src/main/java/org/apache/aurora/scheduler/sla/SlaAlgorithm.java 
> ff73ca6265bd0699791da5e5b6ed4aab9156d9e4 
>   src/main/java/org/apache/aurora/scheduler/sla/SlaModule.java 
> 64e986fb2e0f955dd4a9c7824eac9494728bf24e 
>   src/test/java/org/apache/aurora/scheduler/sla/MetricCalculatorTest.java 
> cb98834e925793fc116814371548a30470830164 
>   src/test/java/org/apache/aurora/scheduler/sla/SlaModuleTest.java 
> 5ee123a03e3c8670e0c03b05c48a9f4c66f6af9d 
> 
> Diff: https://reviews.apache.org/r/35498/diff/
> 
> 
> Testing
> -------
> 
> `./gradlew -Pq build` and a manual verification in Vagrant.
> 
> 
> Thanks,
> 
> Stephan Erb
> 
>

Reply via email to