-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35847/#review89270
-----------------------------------------------------------


Master (d28bd4f) is red with this patch.
  ./build-support/jenkins/build.sh

                     rootdir: 
/home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/python/apache/thermos/common,
 inifile: 
                     plugins: cov, timeout
                     
                     collecting 0 items
                     collecting 3 items
                     collected 3 items 
                     
                     
src/test/python/apache/thermos/common/test_pathspec.py::test_legacy_task_roots 
PASSED
                     
src/test/python/apache/thermos/common/test_pathspec.py::test_legacy_log_dirs 
PASSED
                     
src/test/python/apache/thermos/common/test_pathspec.py::test_exception_on_none_keys
 PASSED
                     
                      generated xml file: 
/home/jenkins/jenkins-slave/workspace/AuroraBot/dist/test-results/src.test.python.apache.thermos.common.test_pathspec.xml
 
                     ============ 3 passed in 0.02 seconds 
============
                     ============== test session starts ===============
                     platform linux2 -- Python 2.7.6 -- py-1.4.29 -- 
pytest-2.7.2 -- 
/home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/pants.venv/bin/python2.7
                     rootdir: 
/home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/python/apache/aurora/client/hooks,
 inifile: 
                     plugins: cov, timeout
                     
                     collecting 0 items
                     collecting 0 items / 1 errors
                     collected 0 items / 1 errors 
                     
                     ===================== ERRORS =====================
                     ____ ERROR collecting test_non_hooked_api.py _____
                     
src/test/python/apache/aurora/client/hooks/test_non_hooked_api.py:18: in 
<module>
                         from apache.aurora.client.hooks.hooked_api import 
NonHookedAuroraClientAPI
                     
/tmp/user/20000/tmpMuyLcT/apache/aurora/client/hooks/hooked_api.py:22: in 
<module>
                         from apache.aurora.client.config import 
GlobalHookRegistry
                     
/tmp/user/20000/tmpMuyLcT/apache/aurora/client/config.py:27: in <module>
                         from apache.aurora.config import AuroraConfig
                     
/tmp/user/20000/tmpMuyLcT/apache/aurora/config/__init__.py:22: in <module>
                         from apache.aurora.config.schema.base import 
MesosContext
                     
/tmp/user/20000/tmpMuyLcT/apache/aurora/config/schema/base.py:59: in <module>
                         class LifecycleConfig(Struct):
                     
/tmp/user/20000/tmpMuyLcT/apache/aurora/config/schema/base.py:60: in 
LifecycleConfig
                         http = HttpLifecycleConfig
                     E   NameError: name 'HttpLifecycleConfig' is not 
defined
                      generated xml file: 
/home/jenkins/jenkins-slave/workspace/AuroraBot/dist/test-results/src.test.python.apache.aurora.client.hooks.non_hooked_api.xml
 
                     ============ 1 error in 0.56 seconds 
=============
                     src.test.python.apache.aurora.client.hooks.non_hooked_api  
                     .....   FAILURE
                     src.test.python.apache.thermos.common.test_pathspec        
                     .....   SUCCESS
                     
FAILURE


               FAILURE


I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On June 24, 2015, 10:13 p.m., Brian Wickman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35847/
> -----------------------------------------------------------
> 
> (Updated June 24, 2015, 10:13 p.m.)
> 
> 
> Review request for Aurora, Brian Brazil and Maxim Khutornenko.
> 
> 
> Bugs: AURORA-1368
>     https://issues.apache.org/jira/browse/AURORA-1368
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Move shutdown endpoints to the Job config since the lifecycle is controlled 
> by Aurora and not Thermos.
> Split the lifecycle management into a composition layer that can more readily 
> be tested.
> 
> Also, derp, just realized I did not update the documentation.  Revision 
> forthcoming.
> (Also comment on the 'union' style here -- not sure what is preferable.)
> 
> 
> Diffs
> -----
> 
>   docs/configuration-reference.md 7bfd63381f54b0fe5ef6a4f17b825049b19038db 
>   src/main/python/apache/aurora/config/schema/base.py 
> 9a6f8a16f85c324ec75352710e19249443bf2c6b 
>   src/main/python/apache/aurora/config/thrift.py 
> 0a3e91011eccf8573feb296bd7f72913622e0ce0 
>   src/main/python/apache/aurora/executor/BUILD 
> cbb2f5f7b5daa936db71cf8c0aac8ddb2002060b 
>   src/main/python/apache/aurora/executor/http_lifecycle.py PRE-CREATION 
>   src/main/python/apache/aurora/executor/thermos_task_runner.py 
> 7bcd6c42f50665eac2e7f17b84e63f2ea7fb4d4f 
>   src/main/python/apache/thermos/config/schema_base.py 
> a85def9eea25fa01020ca2dda4e9cefe861c4a5f 
>   src/test/python/apache/aurora/executor/BUILD 
> f415ecc77022b34f053c35272d004e133803d702 
>   src/test/python/apache/aurora/executor/common/fixtures.py 
> 37d032beb66a67cfd3cfcea272747a2915a745ff 
>   src/test/python/apache/aurora/executor/test_http_lifecycle.py PRE-CREATION 
>   src/test/python/apache/aurora/executor/test_thermos_task_runner.py 
> 3569a6abf84d5144d2e268b0a86c82285ffe2b2b 
> 
> Diff: https://reviews.apache.org/r/35847/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Brian Wickman
> 
>

Reply via email to