> On June 25, 2015, 10:14 a.m., Brian Brazil wrote: > > docs/configuration-reference.md, line 449 > > <https://reviews.apache.org/r/35847/diff/5/?file=991681#file991681line449> > > > > If we're making this configurable, I think that we should make it apply > > to the healthcheck config too. > > > > Does the HealthCheckConfig also belong in lifecycle? I'd consider them > > pretty strongly related.
Coupling them together has always bothered me. The code responsible for health check and the code responsible for lifecycle are two separate modules; I can totally see wanting one and not the other (e.g. we have customers who really don't want health checking because of its tendency to kill all instances simultaneously, while they still want the ability to gracefully drain connections during a rolling update.) Making the port configurable is necessary to do this. The only reason it's "health" by default is for backwards compatibility. - Brian ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35847/#review89335 ----------------------------------------------------------- On June 24, 2015, 10:45 p.m., Brian Wickman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/35847/ > ----------------------------------------------------------- > > (Updated June 24, 2015, 10:45 p.m.) > > > Review request for Aurora, Brian Brazil and Maxim Khutornenko. > > > Bugs: AURORA-1368 > https://issues.apache.org/jira/browse/AURORA-1368 > > > Repository: aurora > > > Description > ------- > > Move shutdown endpoints to the Job config since the lifecycle is controlled > by Aurora and not Thermos. > Split the lifecycle management into a composition layer that can more readily > be tested. > > Also, derp, just realized I did not update the documentation. Revision > forthcoming. > (Also comment on the 'union' style here -- not sure what is preferable.) > > > Diffs > ----- > > docs/configuration-reference.md 7bfd63381f54b0fe5ef6a4f17b825049b19038db > src/main/python/apache/aurora/config/schema/base.py > 9a6f8a16f85c324ec75352710e19249443bf2c6b > src/main/python/apache/aurora/config/thrift.py > 0a3e91011eccf8573feb296bd7f72913622e0ce0 > src/main/python/apache/aurora/executor/BUILD > cbb2f5f7b5daa936db71cf8c0aac8ddb2002060b > src/main/python/apache/aurora/executor/http_lifecycle.py PRE-CREATION > src/main/python/apache/aurora/executor/thermos_task_runner.py > 7bcd6c42f50665eac2e7f17b84e63f2ea7fb4d4f > src/main/python/apache/thermos/config/schema_base.py > a85def9eea25fa01020ca2dda4e9cefe861c4a5f > src/test/python/apache/aurora/executor/BUILD > f415ecc77022b34f053c35272d004e133803d702 > src/test/python/apache/aurora/executor/common/fixtures.py > 37d032beb66a67cfd3cfcea272747a2915a745ff > src/test/python/apache/aurora/executor/test_http_lifecycle.py PRE-CREATION > src/test/python/apache/aurora/executor/test_thermos_task_runner.py > 3569a6abf84d5144d2e268b0a86c82285ffe2b2b > > Diff: https://reviews.apache.org/r/35847/diff/ > > > Testing > ------- > > > Thanks, > > Brian Wickman > >