> On June 9, 2015, 8:18 p.m., Kevin Sweeney wrote:
> > packaging/rpm/aurora.service, line 21
> > <https://reviews.apache.org/r/33778/diff/2/?file=947994#file947994line21>
> >
> >     The scheduler should not run as root

Added support for the creation of an aurora user/group as well as logic to 
support running the scheduler under this user.


> On June 9, 2015, 8:18 p.m., Kevin Sweeney wrote:
> > packaging/rpm/aurora.spec, line 32
> > <https://reviews.apache.org/r/33778/diff/2/?file=947995#file947995line32>
> >
> >     support for 1.7 will be dropped in 0.9.0, I'd prefer we not get new 
> > users stuck here and remove this branch.

Dropped.


> On June 9, 2015, 8:18 p.m., Kevin Sweeney wrote:
> > packaging/rpm/aurora.spec, lines 28-34
> > <https://reviews.apache.org/r/33778/diff/5/?file=963972#file963972line28>
> >
> >     Java 8 is required in 0.9.0 - remove this branching entirely.

Dropped.


> On June 9, 2015, 8:18 p.m., Kevin Sweeney wrote:
> > packaging/rpm/aurora.spec, lines 166-171
> > <https://reviews.apache.org/r/33778/diff/5/?file=963972#file963972line166>
> >
> >     Drop this entirely now that the project is on JDK8?

Dropped.


> On June 9, 2015, 8:18 p.m., Kevin Sweeney wrote:
> > packaging/rpm/aurora.startup.sh, line 21
> > <https://reviews.apache.org/r/33778/diff/5/?file=963973#file963973line21>
> >
> >     the RHS is redundant here if you change GLOG_V to GLOG_v in the 
> > sysconfig file.

Fixed.


> On June 9, 2015, 8:18 p.m., Kevin Sweeney wrote:
> > packaging/rpm/aurora.startup.sh, lines 22-23
> > <https://reviews.apache.org/r/33778/diff/5/?file=963973#file963973line22>
> >
> >     RHS is redundant - you can just do
> >     
> >     ```
> >     export GLOG_v LIBPROCESS_PORT LIBPROCES_IP
> >     ```

Fixed.


> On June 9, 2015, 8:18 p.m., Kevin Sweeney wrote:
> > packaging/rpm/aurora.sysconfig, line 28
> > <https://reviews.apache.org/r/33778/diff/5/?file=963974#file963974line28>
> >
> >     Is this needed? This is the default right?

Alas, the Mesosphere RPM drops the necessary libmesos bits in /usr/lib instead 
of /usr/lib64, which is the default on an EL system, so this forces the JVM 
libloader to look into /usr/lib instead.


- Steve


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33778/#review82436
-----------------------------------------------------------


On May 19, 2015, 4:19 p.m., Steve Salevan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33778/
> -----------------------------------------------------------
> 
> (Updated May 19, 2015, 4:19 p.m.)
> 
> 
> Review request for Aurora, Jake Farrell, Kevin Sweeney, and Bill Farner.
> 
> 
> Bugs: AURORA-1116
>     https://issues.apache.org/jira/browse/AURORA-1116
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> This review board adds support for building Red Hat-flavored packages for the 
> Aurora scheduler alongside its client and Thermos-related binaries:
> 
> aurora - Aurora Scheduler
> aurora-client - Aurora client and admin tool
> aurora-thermos - Thermos executor, runner, and observer
> aurora-debuginfo - Debugging symbols for Python/libmesos integration
> 
> If you'd like to give it a whirl, the following Make targets will spin up new 
> RPMs:
> 
> make (nightly_srpm|nightly_rpm) - builds an RPM or SRPM with timestamped 
> versioning, suitable for producing nightly updates
> make (release_srpm|release_rpm) - builds without timestamped versioning
> 
> Let me know what you think, and thanks!
> 
> 
> Diffs
> -----
> 
>   packaging/rpm/Makefile PRE-CREATION 
>   packaging/rpm/aurora.init.sh PRE-CREATION 
>   packaging/rpm/aurora.logrotate PRE-CREATION 
>   packaging/rpm/aurora.service PRE-CREATION 
>   packaging/rpm/aurora.spec PRE-CREATION 
>   packaging/rpm/aurora.startup.sh PRE-CREATION 
>   packaging/rpm/aurora.sysconfig PRE-CREATION 
>   packaging/rpm/clusters.json PRE-CREATION 
>   packaging/rpm/thermos-observer.init.sh PRE-CREATION 
>   packaging/rpm/thermos-observer.logrotate PRE-CREATION 
>   packaging/rpm/thermos-observer.service PRE-CREATION 
>   packaging/rpm/thermos-observer.startup.sh PRE-CREATION 
>   packaging/rpm/thermos-observer.sysconfig PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/33778/diff/
> 
> 
> Testing
> -------
> 
> Successfully executed builds on EL 6/7 and F19/20, tested deployment on EL6 
> and F19
> 
> 
> Thanks,
> 
> Steve Salevan
> 
>

Reply via email to