> On July 6, 2015, 9:20 p.m., Kevin Sweeney wrote: > > build-support/packaging/rpm/aurora.service, line 20 > > <https://reviews.apache.org/r/33778/diff/12/?file=1000455#file1000455line20> > > > > This is unnecessary according to [1]? > > > > Alternatively you should consider doing `curl -X POST > > http://localhost:8081/quitquitquit`, which will invoke the scheduler > > graceful shutdown logic. > > > > ``` > > If this option is not specified, the process is terminated by sending > > the signal specified in KillSignal= when service stop is requested. > > ``` > > > > [1] > > http://www.freedesktop.org/software/systemd/man/systemd.service.html#ExecStop=
Good catch! I opted for removing this altogether, as systemd will by default send SIGTERM, wait for a timeout, and then send a SIGKILL, which seems like the cleanest way to rock this. - Steve ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33778/#review90566 ----------------------------------------------------------- On July 6, 2015, 9:41 p.m., Steve Salevan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/33778/ > ----------------------------------------------------------- > > (Updated July 6, 2015, 9:41 p.m.) > > > Review request for Aurora, Jake Farrell, Kevin Sweeney, and Bill Farner. > > > Bugs: AURORA-1116 > https://issues.apache.org/jira/browse/AURORA-1116 > > > Repository: aurora > > > Description > ------- > > This review board adds support for building Red Hat-flavored packages for the > Aurora scheduler alongside its client and Thermos-related binaries: > > aurora - Aurora Scheduler > aurora-client - Aurora client and admin tool > aurora-thermos - Thermos executor, runner, and observer > aurora-debuginfo - Debugging symbols for Python/libmesos integration > > If you'd like to give it a whirl, the following Make targets will spin up new > RPMs: > > make (nightly_srpm|nightly_rpm) - builds an RPM or SRPM with timestamped > versioning, suitable for producing nightly updates > make (release_srpm|release_rpm) - builds without timestamped versioning > > Let me know what you think, and thanks! > > > Diffs > ----- > > build-support/packaging/rpm/Makefile PRE-CREATION > build-support/packaging/rpm/README.md PRE-CREATION > build-support/packaging/rpm/aurora.init.sh PRE-CREATION > build-support/packaging/rpm/aurora.logrotate PRE-CREATION > build-support/packaging/rpm/aurora.service PRE-CREATION > build-support/packaging/rpm/aurora.spec PRE-CREATION > build-support/packaging/rpm/aurora.startup.sh PRE-CREATION > build-support/packaging/rpm/aurora.sysconfig PRE-CREATION > build-support/packaging/rpm/clusters.json PRE-CREATION > build-support/packaging/rpm/thermos-observer.init.sh PRE-CREATION > build-support/packaging/rpm/thermos-observer.logrotate PRE-CREATION > build-support/packaging/rpm/thermos-observer.service PRE-CREATION > build-support/packaging/rpm/thermos-observer.startup.sh PRE-CREATION > build-support/packaging/rpm/thermos-observer.sysconfig PRE-CREATION > > Diff: https://reviews.apache.org/r/33778/diff/ > > > Testing > ------- > > Successfully executed builds on EL 6/7 and F19/20, tested deployment on EL6 > and F19 > > > Thanks, > > Steve Salevan > >
