----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36289/#review90853 -----------------------------------------------------------
This patch does not apply cleanly on master (62a432a), do you need to rebase? I will refresh this build result if you post a review containing "@ReviewBot retry" - Aurora ReviewBot On July 8, 2015, 2:06 a.m., Renan DelValle wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36289/ > ----------------------------------------------------------- > > (Updated July 8, 2015, 2:06 a.m.) > > > Review request for Aurora. > > > Repository: aurora > > > Description > ------- > > What was done: > ============== > Added support for custom executors in the Scheduler via a config file. > Removed command line arguments that were moved over to the config file. > > Future: > ======= > Extending the client to support custom executors. > > Caveats: > ======== > This contains initial config file with support for thermos and limited > support for the mesos commandline executor. Mesos-command line executor needs > support from the client side in order to function at a better capacity. > > Currently, this uses the current client to launch both tasks, meaning as long > as the client sends a thrift call, the scheduler will schedule a task, be it > a mesos-command task with a preconfigured command temporarily set in the > config file or a custom executor task. > > *Support for custom executors in the client must be added in order to fully > utilize this feature.* > > > Diffs > ----- > > build.gradle 78159932388046883494dda97b4a86c06772d26d > examples/vagrant/upstart/aurora-scheduler.conf > 1c2390f0248e91e65a548e67f6af1be8d2526b0a > gradle/wrapper/gradle-wrapper.jar 085a1cdc27db1185342f15a00441734e74fe3735 > gradle/wrapper/gradle-wrapper.properties > e713793f7d63e65ea68e091b959ba6a68352b48f > gradlew dd29ec5eae9a34d216475d6e5b5d8c810885aa76 > src/dist/etc/executors.json PRE-CREATION > src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java > 554a380bdb4ef69561259cdbfbc361694041571e > > src/main/java/org/apache/aurora/scheduler/configuration/ExecutorSettingsLoader.java > PRE-CREATION > src/main/java/org/apache/aurora/scheduler/mesos/ExecutorSettings.java > 325f55640648151ae19e0c18c6961aeff10bfac3 > src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java > c0d165ad34e46653dad95918e0058ebd3f2ee57f > > Diff: https://reviews.apache.org/r/36289/diff/ > > > Testing > ------- > > ./gradlew test > 895 tests completed, 44 failed, 3 skipped > > > Thanks, > > Renan DelValle > >
