> On July 9, 2015, 6:05 p.m., Zameer Manji wrote:
> > src/main/java/org/apache/aurora/scheduler/storage/db/DbModule.java, line 115
> > <https://reviews.apache.org/r/36357/diff/1/?file=1003739#file1003739line115>
> >
> >     Once H2 becomes the default/only in memory storage, are we going to 
> > revisit the LOCK_MODE?

Yes.  My TODO in the newly-added test case advises this.


> On July 9, 2015, 6:05 p.m., Zameer Manji wrote:
> > src/test/java/org/apache/aurora/scheduler/storage/AbstractTaskStoreTest.java,
> >  line 616
> > <https://reviews.apache.org/r/36357/diff/1/?file=1003740#file1003740line616>
> >
> >     Why not a lambda here?

I have not fallen into the default mode of using lambdas just yet because there 
are unresolved issues with checkstyle, pmd, and guice 3.0.  I've changed this 
one since it does not upset these tools.


> On July 9, 2015, 6:05 p.m., Zameer Manji wrote:
> > src/test/java/org/apache/aurora/scheduler/storage/AbstractTaskStoreTest.java,
> >  line 630
> > <https://reviews.apache.org/r/36357/diff/1/?file=1003740#file1003740line630>
> >
> >     Why not a lambda here?

Checkstyle does not permit this.  There are several relevant open issues, for 
example: https://github.com/checkstyle/checkstyle/issues/577


- Bill


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36357/#review91132
-----------------------------------------------------------


On July 9, 2015, 5:59 p.m., Bill Farner wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36357/
> -----------------------------------------------------------
> 
> (Updated July 9, 2015, 5:59 p.m.)
> 
> 
> Review request for Aurora and Zameer Manji.
> 
> 
> Bugs: AURORA-1386
>     https://issues.apache.org/jira/browse/AURORA-1386
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> See h2 docs [1] for context on this setting.
> 
> The patch in `DbModule` could have been much smaller, but i did a mini 
> refactor to supply a map of args to centralize concatenation and make for 
> easier commenting on each arg.
> 
> [1] http://www.h2database.com/html/advanced.html#transaction_isolation
> 
> 
> Diffs
> -----
> 
>   src/main/java/org/apache/aurora/scheduler/storage/db/DbModule.java 
> 23bf0acf33b7a130bec98e33259bde1b3dc5c7cb 
>   
> src/test/java/org/apache/aurora/scheduler/storage/AbstractTaskStoreTest.java 
> c8a2d81bfc48ee8d9cb81aecea1baba920b2b948 
> 
> Diff: https://reviews.apache.org/r/36357/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Bill Farner
> 
>

Reply via email to