-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36392/#review91609
-----------------------------------------------------------
Master (1a01a5b) is red with this patch.
./build-support/jenkins/build.sh
Collecting twitter.common.util==0.3.0 (from
twitter.common.app==0.3.0->twitter.checkstyle==0.1.0)
Using cached twitter.common.util-0.3.0.tar.gz
Collecting twitter.common.collections==0.3.0 (from
twitter.common.app==0.3.0->twitter.checkstyle==0.1.0)
Using cached twitter.common.collections-0.3.0.tar.gz
Collecting smmap>=0.8.5 (from
gitdb>=0.5.1->GitPython==0.3.2.RC1->twitter.checkstyle==0.1.0)
Using cached smmap-0.9.0.tar.gz
Collecting twitter.common.string==0.3.0 (from
twitter.common.process==0.3.0->twitter.common.app==0.3.0->twitter.checkstyle==0.1.0)
Using cached twitter.common.string-0.3.0.tar.gz
Collecting twitter.common.options==0.3.0 (from
twitter.common.log==0.3.0->twitter.common.app==0.3.0->twitter.checkstyle==0.1.0)
Using cached twitter.common.options-0.3.0.tar.gz
Collecting twitter.common.dirutil==0.3.0 (from
twitter.common.log==0.3.0->twitter.common.app==0.3.0->twitter.checkstyle==0.1.0)
Using cached twitter.common.dirutil-0.3.0.tar.gz
Collecting twitter.common.contextutil==0.3.0 (from
twitter.common.util==0.3.0->twitter.common.app==0.3.0->twitter.checkstyle==0.1.0)
Using cached twitter.common.contextutil-0.3.0.tar.gz
Collecting twitter.common.lang==0.3.0 (from
twitter.common.collections==0.3.0->twitter.common.app==0.3.0->twitter.checkstyle==0.1.0)
Using cached twitter.common.lang-0.3.0.tar.gz
Installing collected packages: pyflakes, pep8, smmap, gitdb, GitPython,
twitter.common.lang, twitter.common.string, twitter.common.process,
twitter.common.options, twitter.common.dirutil, twitter.common.log,
twitter.common.contextutil, twitter.common.util, twitter.common.collections,
twitter.common.app, twitter.checkstyle
Running setup.py install for pyflakes
Running setup.py install for pep8
Running setup.py install for smmap
Running setup.py install for gitdb
Running setup.py install for GitPython
Running setup.py install for twitter.common.lang
Running setup.py install for twitter.common.string
Running setup.py install for twitter.common.process
Running setup.py install for twitter.common.options
Running setup.py install for twitter.common.dirutil
Running setup.py install for twitter.common.log
Running setup.py install for twitter.common.contextutil
Running setup.py install for twitter.common.util
Running setup.py install for twitter.common.collections
Running setup.py install for twitter.common.app
Running setup.py install for twitter.checkstyle
Successfully installed GitPython-0.3.2rc1 gitdb-0.6.4 pep8-1.4.5 pyflakes-0.7.2
smmap-0.9.0 twitter.checkstyle-0.1.0 twitter.common.app-0.3.0
twitter.common.collections-0.3.0 twitter.common.contextutil-0.3.0
twitter.common.dirutil-0.3.0 twitter.common.lang-0.3.0 twitter.common.log-0.3.0
twitter.common.options-0.3.0 twitter.common.process-0.3.0
twitter.common.string-0.3.0 twitter.common.util-0.3.0
E501:ERROR src/test/python/apache/aurora/client/cli/test_diff.py:096 line too
long (103 > 100 characters)
| assert
subprocess_patch.call_args[0][0].startswith(os.environ.get('DIFF_VIEWER',
'diff') + ' ')
T301:ERROR src/main/python/apache/aurora/client/cli/jobs.py:177 Expected 1
blank lines, found 0
| def __repr__(self):
I will refresh this build result if you post a review containing "@ReviewBot
retry"
- Aurora ReviewBot
On July 14, 2015, 12:31 p.m., Brian Brazil wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36392/
> -----------------------------------------------------------
>
> (Updated July 14, 2015, 12:31 p.m.)
>
>
> Review request for Aurora, Bill Farner and Brian Wickman.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Use json.dumps to pretty print the executor config,
> and munge it to look right and not get messed with by
> the general pretty printer.
> Show newlines directly so that multi-line cmdlines look right.
>
> Make DIFF_VIEWER work for things like "diff -u10"
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/client/cli/jobs.py
> 5f608419e1235f14836865b46be05d13963deb37
> src/test/python/apache/aurora/client/cli/test_diff.py
> da52105b5c77419ff64e15a30a04f997f9216a7e
>
> Diff: https://reviews.apache.org/r/36392/diff/
>
>
> Testing
> -------
>
> Tested in vargant environment.
>
>
> Thanks,
>
> Brian Brazil
>
>
