-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36436/#review91645
-----------------------------------------------------------



src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 
(lines 168 - 177)
<https://reviews.apache.org/r/36436/#comment145170>

    Have you considered a single arg for the upper bound of instance events 
that are allowed for a job update?  I think this would be easier for the 
operator to reason about, and simpler to associate directly to DB impact.


- Bill Farner


On July 13, 2015, 11:10 p.m., Joe Smith wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36436/
> -----------------------------------------------------------
> 
> (Updated July 13, 2015, 11:10 p.m.)
> 
> 
> Review request for Aurora and Bill Farner.
> 
> 
> Bugs: AURORA-1096
>     https://issues.apache.org/jira/browse/AURORA-1096
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Prevent job updates from allowing unbounded instance events
> 
> 
> Diffs
> -----
> 
>   
> src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java
>  dc0cd2d71d11b8157154f7b63a14f0282dee09f1 
>   
> src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
>  d28baba7618ebb194a61455971786aef46abd8eb 
> 
> Diff: https://reviews.apache.org/r/36436/diff/
> 
> 
> Testing
> -------
> 
> `./gradlew build -Pq`
> 
> 
> Thanks,
> 
> Joe Smith
> 
>

Reply via email to