> On July 15, 2015, 7:08 p.m., Bill Farner wrote:
> > src/main/java/org/apache/aurora/scheduler/app/ExecutorSettingsLoader.java, 
> > line 57
> > <https://reviews.apache.org/r/36289/diff/2/?file=1011919#file1011919line57>
> >
> >     Please model your configuration as an object, and let Gson do the heavy 
> > lifting for you.  As a starting point, it will probably be something like 
> > this (source trimmed for conciseness):
> >     
> >     
> >     ```
> >     class ExecutorConfig {
> >       String name;
> >       String path;
> >       String arguments;
> >       Set<String> resources;
> >       ...
> >     }
> >     ```
> >     
> >     Then have gson read `List<ExecutorConfig>`.
> >     
> >     We'll probably want to have one field that is something like 
> > `JsonObject` so that the executor can have a snippet of custom schema.

Aw shucks! Seems so obvious now that you mention it. I went ahead and did that, 
made my life a lot easier. 

One thing to note is that thrift already generates an ExecutorConfig class at 
org/apache/aurora/gen/ExecutorConfig.java 

Is it OK to have a second class in 
org/apache/aurora/scheduler/app/ExecutorConfig.java with the same name?


> On July 15, 2015, 7:08 p.m., Bill Farner wrote:
> > src/dist/etc/executors.json, line 1
> > <https://reviews.apache.org/r/36289/diff/2/?file=1011918#file1011918line1>
> >
> >     Please move this file to `examples/vagrant`, as this configuration is 
> > not suitable for distribution to others.

Done, however, in order to launch the service in the vagrant image sucessfully, 
we need a configuration file. How should we address this?


- Renan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36289/#review91793
-----------------------------------------------------------


On July 15, 2015, 1:13 a.m., Renan DelValle wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36289/
> -----------------------------------------------------------
> 
> (Updated July 15, 2015, 1:13 a.m.)
> 
> 
> Review request for Aurora.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> What was done:
> ==============
> Added support for custom executors in the Scheduler via a config file. 
> Removed command line arguments that were moved over to the config file.
> 
> Future:
> =======
> Extending the client to support custom executors and the mesos-executor.
> 
> Caveats:
> ========
> This contains initial config file with support for thermos and limited 
> support for the mesos commandline executor. Mesos-command line executor needs 
> support from the client side in order to function at a better capacity. 
> 
> Currently, this uses the current client to launch both tasks, meaning as long 
> as the client sends a thrift call, the scheduler will schedule a task, be it 
> a mesos-command task with a preconfigured command temporarily set in the 
> config file or a custom executor task. 
> 
> *Support for custom executors in the client must be added in order to fully 
> utilize this feature.*
> 
> 
> Diffs
> -----
> 
>   examples/vagrant/upstart/aurora-scheduler-kerberos.conf 
> 85052ac8e4dde85fbcd85ce839d0647f5632d74b 
>   examples/vagrant/upstart/aurora-scheduler.conf 
> f261c8dcc760151d5a41a986d867585c3a544123 
>   src/dist/etc/executors.json PRE-CREATION 
>   src/main/java/org/apache/aurora/scheduler/app/ExecutorSettingsLoader.java 
> PRE-CREATION 
>   src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java 
> 554a380bdb4ef69561259cdbfbc361694041571e 
>   src/main/java/org/apache/aurora/scheduler/mesos/ExecutorSettings.java 
> 325f55640648151ae19e0c18c6961aeff10bfac3 
>   src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java 
> c0d165ad34e46653dad95918e0058ebd3f2ee57f 
>   
> src/test/java/org/apache/aurora/scheduler/app/ExecutorSettingsLoaderTest.java 
> PRE-CREATION 
>   src/test/java/org/apache/aurora/scheduler/app/SchedulerIT.java 
> 23c2693f1dfd589043c60ab22e302fb81e62335d 
>   
> src/test/java/org/apache/aurora/scheduler/mesos/MesosTaskFactoryImplTest.java 
> c0cadfb34ade55bdb38ab2c0f89499bd6e8fa97a 
>   src/test/java/org/apache/aurora/scheduler/mesos/TaskExecutors.java 
> ebd81775c5c9f0ef5c309869df1d12dca3ddbdd7 
>   
> src/test/resources/org/apache/aurora/scheduler/app/executor-settings-example.json
>  PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/36289/diff/
> 
> 
> Testing
> -------
> 
> Ran jenkins build test, passed all tests, code style checks, findbugs check, 
> and PMD.
> 
> 
> Thanks,
> 
> Renan DelValle
> 
>

Reply via email to