-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36644/#review92469
-----------------------------------------------------------

Ship it!


Thanks for catching and patching this!

- Bill Farner


On July 21, 2015, 5:02 p.m., Andrew Jorgensen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36644/
> -----------------------------------------------------------
> 
> (Updated July 21, 2015, 5:02 p.m.)
> 
> 
> Review request for Aurora, Benjamin Staffin, Brian Wickman, and Zameer Manji.
> 
> 
> Bugs: AURORA-1403
>     https://issues.apache.org/jira/browse/AURORA-1403
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> The old thermos_observer is missing the --mesos-root flag thats needed
> to tell the thermos_observer where it can find the mesos root directory.
> It currently defaults to /var/lib/mesos in the old observer entry point.
> 
> 
> Diffs
> -----
> 
>   build-support/packaging/debian/rules 
> db0f14ebd0493e47b839e33ee0f408c516fab0e1 
> 
> Diff: https://reviews.apache.org/r/36644/diff/
> 
> 
> Testing
> -------
> 
> 1. Built aurora with dpkg-buildpackage -us -uc -d
> 2. Installed executor deb: dpkg --install 
> aurora-executor_0.9.0-SNAPSHOT_amd64.deb
> 3. thermos_observer --long-help
> Options:
>   -h, --help, --short-help
>                         show this help message and exit.
>   --long-help           show options from all registered modules, not just the
>                         __main__ module.
>   --root=ROOT           The thermos checkpoint root directory to search for
>                         Thermos tasks [default: /var/run/thermos]
>   --mesos-root=MESOS_ROOT
>                         The mesos root directory to search for Thermos
>                         executor sandboxes [default: /var/lib/mesos]
>   --port=PORT           The port on which the observer should listen.
>                         [default: 1338]
>   --polling_interval_secs=POLLING_INTERVAL_SECS
>                         The number of seconds between observer refresh
>                         attempts. [default: 5]
> 
> I am in the process of building and deploying this change to production and 
> can report back when that is complete.
> 
> 
> Thanks,
> 
> Andrew Jorgensen
> 
>

Reply via email to