----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36671/#review92527 -----------------------------------------------------------
Ship it! Thanks! build.gradle (line 223) <https://reviews.apache.org/r/36671/#comment146732> Some advice would really round this out. How about "Consider setting JAVA_HOME to select a specific JDK on your system." - Bill Farner On July 22, 2015, 2:47 a.m., Joshua Cohen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36671/ > ----------------------------------------------------------- > > (Updated July 22, 2015, 2:47 a.m.) > > > Review request for Aurora and Bill Farner. > > > Repository: aurora > > > Description > ------- > > Enforce a minimum java version rather than failing to compile when language > features are not available in the current JDK. > > > Diffs > ----- > > build.gradle 69e4a911eb320b9088795bdcdfcbd45b234f52df > > Diff: https://reviews.apache.org/r/36671/diff/ > > > Testing > ------- > > Built w/ JDK7: > > FAILURE: Build failed with an exception. > > * Where: > Build file > '/Users/jcohen/workspace/external/incubator-aurora/build.gradle' line: 222 > > * What went wrong: > A problem occurred evaluating root project 'aurora'. > > Build requires at least Java 1.8; but 1.7 was found. > > Build succeeds w/ JDK8. > > > Thanks, > > Joshua Cohen > >
