-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36709/#review92661
-----------------------------------------------------------

Ship it!


Nice find.

- Zameer Manji


On July 22, 2015, 3:13 p.m., Kevin Sweeney wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36709/
> -----------------------------------------------------------
> 
> (Updated July 22, 2015, 3:13 p.m.)
> 
> 
> Review request for Aurora, Joshua Cohen and Bill Farner.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Remove generated FROM_BUILDER and TO_BUILDER methods.
> 
> With method references in Java 8 these are no longer needed. Method 
> references have the additional advantage that they can be used in functions 
> that take either `com.google.common.base.Function` or 
> `java.util.function.Function` (or any other functional interface).
> 
> 
> Diffs
> -----
> 
>   src/main/java/org/apache/aurora/scheduler/http/StructDump.java 
> 05434f8bfdd8165ab8a333b15301e1f0f46578dd 
>   
> src/main/java/org/apache/aurora/scheduler/http/api/security/ShiroAuthorizingParamInterceptor.java
>  a95e1ecff92fb1e192baaa1edda1c0c837aabe0a 
>   src/main/java/org/apache/aurora/scheduler/storage/db/DbAttributeStore.java 
> 1b274c8f1cc534aea65a1eecc05b3c9e85e35409 
>   src/main/java/org/apache/aurora/scheduler/storage/db/DbQuotaStore.java 
> 9371907374ffaf1082d8e9d224260d9a67ae1fb7 
>   src/main/python/apache/aurora/tools/java/thrift_wrapper_codegen.py 
> f3d92884dc1d35d576bbe84f70be6e46278444ed 
>   
> src/test/java/org/apache/aurora/scheduler/storage/entities/IHostAttributesTest.java
>  05b31c2f75da9df53ab66007a1e907900ed90cd0 
> 
> Diff: https://reviews.apache.org/r/36709/diff/
> 
> 
> Testing
> -------
> 
> ./gradlew -Pq clean build
> 
> 
> Thanks,
> 
> Kevin Sweeney
> 
>

Reply via email to