----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34337/#review92671 -----------------------------------------------------------
Ship it! Ship It! - Bill Farner On July 18, 2015, 11:50 p.m., Mauricio Garavaglia wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/34337/ > ----------------------------------------------------------- > > (Updated July 18, 2015, 11:50 p.m.) > > > Review request for Aurora and Bill Farner. > > > Repository: aurora > > > Description > ------- > > Support Arbitrary Docker Parameters in DockerContainer > > > Diffs > ----- > > api/src/main/thrift/org/apache/aurora/gen/api.thrift > d740a90e7732f42b43a79f8cf0afe705c061539c > docs/configuration-reference.md dafd306d672d9eb417394dc0cf49c7ac86695454 > > src/main/java/org/apache/aurora/scheduler/configuration/ConfigurationManager.java > be79e70faa7125eee407fc57e8a297e18a51661f > src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java > c0d165ad34e46653dad95918e0058ebd3f2ee57f > src/main/python/apache/aurora/config/schema/base.py > d1f1e4f8082553f3a773e70a7f5cd0c48181ae8c > src/main/python/apache/aurora/config/thrift.py > 88dd1c7cf2e5a9bfbe827bc342d49f7a18bc8558 > > src/test/java/org/apache/aurora/scheduler/mesos/MesosTaskFactoryImplTest.java > c0cadfb34ade55bdb38ab2c0f89499bd6e8fa97a > src/test/python/apache/aurora/config/test_thrift.py > f48ac88c076c12541626b497ca4fc47e5941dd31 > > Diff: https://reviews.apache.org/r/34337/diff/ > > > Testing > ------- > > Used Docker as the container of a Job. Included volumes and label parameters > which are correctly picked up by mesos when starting the task. The docker > container gets the specified label and bind mounts the volumes correctly. > I've been running multiple PostgreSQL databases docker containers for several > weeks deploying them as aurora jobs. > > > Thanks, > > Mauricio Garavaglia > >