-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36711/#review92680
-----------------------------------------------------------


This patch does not apply cleanly on master (38c2e76), do you need to rebase?

I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On July 22, 2015, 11:18 p.m., Kevin Sweeney wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36711/
> -----------------------------------------------------------
> 
> (Updated July 22, 2015, 11:18 p.m.)
> 
> 
> Review request for Aurora, Bill Farner and Zameer Manji.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Remove all public static com.google.common.base.Functions
> 
> This change removes all public static Functions and either replaces them with 
> static methods or inlines them (if they could have been replaced by method 
> references). The benefit of this change is that these library functions are 
> now usable as `com.google.common.base.Function`s (in the case of guava 
> methods), `java.util.function.Function`s (in the case of the Java 8 standard 
> library), and directly (by callers that were previously invoking them via 
> `.apply`).
> 
> This change was almost entirely IDE-driven, with the exception of the direct 
> calls (IntelliJ inlines `Tasks.ASSIGNED_TO_ID.apply(assignedTask)` as 
> `((Function<IAssignedTask, String) IAssignedTask::getId).apply(assignedTask)` 
> rather than `assignedTask.getId()`).
> 
> Since overloads work now and we generally don't repeat the type in the method 
> name, some names were shortened (for example `Tasks.SCHEDULED_TO_INSTANCE_ID` 
> was renamed to `Tasks#getInstanceId(ScheduledTask)`.
> 
> I chose to only include `public static` Functions in this review to avoid a 
> diff size explosion.
> 
> 
> Diffs
> -----
> 
>   src/main/java/org/apache/aurora/Protobufs.java 
> 7f1789531bc7fc83dba6e19b39e74f3333a7232a 
>   src/main/java/org/apache/aurora/scheduler/async/RescheduleCalculator.java 
> 6a0c0a9b933546c1581d3e29ba53eb86c58fbc39 
>   src/main/java/org/apache/aurora/scheduler/async/TaskGroups.java 
> 1580404a36bbab6b612b8188c4a649d4a77118e0 
>   src/main/java/org/apache/aurora/scheduler/async/TaskHistoryPruner.java 
> 7b6c0639fba6a322529f17c9a69c3b28ea7d2432 
>   src/main/java/org/apache/aurora/scheduler/async/TaskScheduler.java 
> a500e55cb52fe89917d8499a42e2a2eb5032c109 
>   
> src/main/java/org/apache/aurora/scheduler/async/preemptor/PendingTaskProcessor.java
>  1f1eb4c1f2f2b995d616b70ba9e3d149eea413d0 
>   src/main/java/org/apache/aurora/scheduler/base/JobKeys.java 
> a5ffa5e95b301e536a84acf02817ea0c080559d0 
>   src/main/java/org/apache/aurora/scheduler/base/TaskGroupKey.java 
> 47e4d48ab4c82b2770a6817666dbd24c3e387b48 
>   src/main/java/org/apache/aurora/scheduler/base/Tasks.java 
> 52d37e255edbabc9874591b7a4cb3e096ac51ecc 
>   src/main/java/org/apache/aurora/scheduler/filter/AttributeAggregate.java 
> ae7458c7ea1bb624d0d10539e2ef9f34a77411de 
>   src/main/java/org/apache/aurora/scheduler/http/Maintenance.java 
> 303f05cbec7a7134b39ad1d15af3ee5e7a793e0c 
>   src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java 
> c0d165ad34e46653dad95918e0058ebd3f2ee57f 
>   src/main/java/org/apache/aurora/scheduler/metadata/NearestFit.java 
> 2b194e5a761cb193a2b72419db1a1120fb52c9fe 
>   src/main/java/org/apache/aurora/scheduler/quota/QuotaManager.java 
> 61b8e57b0ee62a706433de9376e81b21af7e9e08 
>   src/main/java/org/apache/aurora/scheduler/sla/MetricCalculator.java 
> 7dca57490fc521fd7497b991aa8778f68b92b03b 
>   src/main/java/org/apache/aurora/scheduler/sla/SlaAlgorithm.java 
> 42967dff996710d3ec1172f481e1f1fb99a20b03 
>   src/main/java/org/apache/aurora/scheduler/sla/SlaGroup.java 
> a1d6c9d6857d2bacfcc7e4719ef2b42b66a9b470 
>   src/main/java/org/apache/aurora/scheduler/state/MaintenanceController.java 
> 441f828da2466288136124f2184aae0d5507848b 
>   src/main/java/org/apache/aurora/scheduler/state/StateManagerImpl.java 
> ff33d0ba01794b3308be4a8baa04b4f8dbb82d3c 
>   src/main/java/org/apache/aurora/scheduler/state/TaskStateMachine.java 
> 4f453e43e21f170293449853f28be49ba0fcb5f8 
>   src/main/java/org/apache/aurora/scheduler/stats/ResourceCounter.java 
> ca0c0b56a6cc8f7df782763cdc6ff77447cdd09a 
>   src/main/java/org/apache/aurora/scheduler/storage/AttributeStore.java 
> 36bdc819a57cc59c6b8eff7d9d0261408aa1fc8a 
>   
> src/main/java/org/apache/aurora/scheduler/storage/backup/TemporaryStorage.java
>  d0156d330deb5d862fa54513fdbb6561d1c91548 
>   
> src/main/java/org/apache/aurora/scheduler/storage/log/WriteAheadStorage.java 
> 0b5530478b6b43b87dbf095a3b4c53dc33eaddcf 
>   src/main/java/org/apache/aurora/scheduler/storage/mem/MemTaskStore.java 
> 42c11192649c1f068efa8e118818d4b27273d809 
>   src/main/java/org/apache/aurora/scheduler/thrift/ReadOnlySchedulerImpl.java 
> 92c970c34ca9dc4f052760e5a3d3770a089d9a67 
>   
> src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java
>  22786dedd0db014f518eb5701a985559d189adad 
>   src/main/java/org/apache/aurora/scheduler/updater/InstanceUpdater.java 
> 722dba4f3dc98efeed7128bfa1f2ae02f4670972 
>   src/main/java/org/apache/aurora/scheduler/updater/JobDiff.java 
> ab540a59b2297cec76190f4df10cc816d9e1ea97 
>   
> src/main/java/org/apache/aurora/scheduler/updater/JobUpdateEventSubscriber.java
>  134cd5429512338d0a464b1f3ffa557ca99d5713 
>   src/test/java/org/apache/aurora/scheduler/async/TaskHistoryPrunerTest.java 
> 6eaf3ce765c8e50b6724e40848ceb9105e1ab529 
>   src/test/java/org/apache/aurora/scheduler/async/TaskSchedulerImplTest.java 
> 45adb2efc8807e22b923cb5606d797758f063297 
>   src/test/java/org/apache/aurora/scheduler/stats/ResourceCounterTest.java 
> ed834bce2f1502605a8ef83d2812eea184bcc0a9 
>   
> src/test/java/org/apache/aurora/scheduler/storage/AbstractTaskStoreTest.java 
> 775bb71f94582020643c12fd19a15d0d6732c699 
>   
> src/test/java/org/apache/aurora/scheduler/storage/mem/StorageTransactionTest.java
>  4ae194c4f86b609729cfdfdaeda369733efae0b2 
>   
> src/test/java/org/apache/aurora/scheduler/thrift/ReadOnlySchedulerImplTest.java
>  ddabb4c04ef329d372504f2fbef597be004e62f1 
>   src/test/java/org/apache/aurora/scheduler/updater/JobUpdaterIT.java 
> 8b99e0fac429bcbb16bd769890dcae902e3f022e 
> 
> Diff: https://reviews.apache.org/r/36711/diff/
> 
> 
> Testing
> -------
> 
> ./gradlew -Pq build
> 
> 
> Thanks,
> 
> Kevin Sweeney
> 
>

Reply via email to