> On July 23, 2015, 12:11 a.m., Kevin Sweeney wrote:
> > src/main/java/org/apache/aurora/scheduler/async/GatedScheduledExecutorService.java,
> >  line 36
> > <https://reviews.apache.org/r/36710/diff/1/?file=1019150#file1019150line36>
> >
> >     Consider extending 
> > http://docs.guava-libraries.googlecode.com/git-history/release/javadoc/com/google/common/util/concurrent/ForwardingListeningExecutorService.html
> >  instead, for the reasons outlined in 
> > https://code.google.com/p/guava-libraries/wiki/ListenableFutureExplained
> 
> Bill Farner wrote:
>     As you may not have noticed, i am returning `null` from all 
> Future-providing methods since we never actually use the return values (and 
> it would add complexity to support Futures).  If we go this route, the 
> richness of listenable futures is moot.
> 
> Kevin Sweeney wrote:
>     Is maintaining the ExecutorService interface necessary for some call 
> sites you intend to replace? Would it be reasonable make this a new interface 
> without the partial implementation?

Thanks for pushing - i started down that path originally, but convinced myself 
that we needed to implement at least `ExecutorService` for `AsyncEventBus` 
purposes, but that only requires `Executor`.  This will slim things down 
considerably, will post a new diff shortly.


- Bill


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36710/#review92685
-----------------------------------------------------------


On July 23, 2015, 12:07 a.m., Bill Farner wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36710/
> -----------------------------------------------------------
> 
> (Updated July 23, 2015, 12:07 a.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Zameer Manji.
> 
> 
> Bugs: AURORA-1395
>     https://issues.apache.org/jira/browse/AURORA-1395
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> This will be used by the rest of the system to manage deferment of work until 
> a transaction has completed.
> 
> TODO(wfarner): I need to document the newly-added interfaces, please assume i 
> will add that shortly.
> 
> 
> Diffs
> -----
> 
>   src/main/java/org/apache/aurora/scheduler/async/DeferredWork.java 
> PRE-CREATION 
>   src/main/java/org/apache/aurora/scheduler/async/FlushableWorkQueue.java 
> PRE-CREATION 
>   
> src/main/java/org/apache/aurora/scheduler/async/GatedScheduledExecutorService.java
>  PRE-CREATION 
>   src/main/java/org/apache/aurora/scheduler/async/TimeDeferredWork.java 
> PRE-CREATION 
>   src/main/java/org/apache/aurora/scheduler/events/PubsubEventModule.java 
> c85979dedd0ef2c515453a33c9a36d52865eb548 
>   
> src/test/java/org/apache/aurora/scheduler/async/GatedScheduledExecutorServiceTest.java
>  PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/36710/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Bill Farner
> 
>

Reply via email to