-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34020/#review93665
-----------------------------------------------------------

Ship it!



src/main/java/org/apache/aurora/scheduler/TaskVars.java (line 255)
<https://reviews.apache.org/r/34020/#comment148076>

    This is not generally the right thing to do, as jdk logging allows you to 
configure this externally with configuration.  However, i don't see a great 
alternative that allows us to pick a sane default for other users of the 
software.  Please at least leave a TODO here and in the other file indicating 
why you're doing this.


- Bill Farner


On July 30, 2015, 10:02 p.m., Joe Smith wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34020/
> -----------------------------------------------------------
> 
> (Updated July 30, 2015, 10:02 p.m.)
> 
> 
> Review request for Aurora and Bill Farner.
> 
> 
> Bugs: AURORA-1282
>     https://issues.apache.org/jira/browse/AURORA-1282
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Change the log level for Stats- this will prevent spurious log messages for 
> domain-acceptable stats names.
> 
> Stat names will be unchanged as a result of this.
> 
> 
> Diffs
> -----
> 
>   src/main/java/org/apache/aurora/scheduler/TaskVars.java 
> 54d893e4bf02d4a49b445a0894b015e62deaf893 
>   src/main/java/org/apache/aurora/scheduler/sla/MetricCalculator.java 
> a47da095de7c602fca8841e7f17a9dc4f78d0478 
> 
> Diff: https://reviews.apache.org/r/34020/diff/
> 
> 
> Testing
> -------
> 
> $ ./gradlew build -Pq
> 
> 
> Thanks,
> 
> Joe Smith
> 
>

Reply via email to