> On July 31, 2015, 10:57 p.m., Joshua Cohen wrote: > > I'm -1 to shipping without something under docs/ explaining this > > organizational structure. > > Bill Farner wrote: > maybe a README.md under `src/main/python/apache` instead? > > Kevin Sweeney wrote: > I've added a new file docs/build-system.md
Thanks! - Joshua ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36972/#review93805 ----------------------------------------------------------- On July 31, 2015, 11:22 p.m., Kevin Sweeney wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36972/ > ----------------------------------------------------------- > > (Updated July 31, 2015, 11:22 p.m.) > > > Review request for Aurora, Bill Farner and Brian Wickman. > > > Bugs: AURORA-1381 > https://issues.apache.org/jira/browse/AURORA-1381 > > > Repository: aurora > > > Description > ------- > > This is a mostly red code diff and makes the pants build work similar to how > it already works in an IDE environment while minimizing duplicated > information. This change also removes the confusing versions of `thermos` and > `thermos_observer` in favor of new ones. Because of the way "covering > dependencies" were required it was easier to do this refactor than more > tactically create a working `setup_py` target for `apache.aurora.tools` > without cycles and without duplicated files. > > * Remove the `apache.thermos` package. > * Rename the `apache.gen.aurora` package to `apache.aurora.thrift`. > * Rename the `apache.gen.thermos` package to `apache.thermos.thrift`. > * Introduce a new `apache.aurora.tools` package with the `thermos` and > `thermos_observer` binaries. > * Create apache.thermos.runner package, rename `thermos/bin` to > `thermos/runner`. > * Remove all `*-packaged` and virtual dependency trees, as well as the phrase > "covering dependencies." > * Use `_`-prefix naming convention for private target names. > * Replace manual list of targets in `make-python-sdists` with > automatically-generated one (using new convention). > * Introduce a new `apache.aurora.kerberos` package with the `kaurora` and > `kaurora_admin` binaries. > * Remove all `BUILD` files in `src/main` that don't contain an exported > `setup.py` library (except one mentioned in TODO). > * Use dictionary syntax in `with_binaries`. > * Remove unused/unreachable binaries (most `bin/` dirs under `thermos/`). > * Create blank `__init__.py` files in directories that pants warns aren't > packages. > * Added `thermos` command to vagrant image. > > > Diffs > ----- > > NEWS 0a8500c524a92eaf51384125687128d2fbbb0b53 > api/src/main/thrift/org/apache/aurora/gen/BUILD > d196fefc2c5e5ee32d0cf9c901cffe7d247379d1 > api/src/main/thrift/org/apache/thermos/BUILD > d0d789a6ee3971e3070f9397d53929563a77f7ea > build-support/packaging/debian/rules > 17e00c02a3cb3294d5107516d795a73587ca4f70 > build-support/packaging/rpm/aurora.spec > 7cf8de6f7b99788ca461a90fc4aefba7dccd7b63 > build-support/release/make-python-sdists > 9608f68e16243da01434ce2fc7d61bb7c7efd712 > docs/README.md 9893763cb75faf1aeb66ed905e9f696d4b532d16 > docs/build-system.md PRE-CREATION > examples/vagrant/aurorabuild.sh fbaa6ae9ef7ff2910af8c9c0d6b8ef90ea3e152a > src/main/python/apache/aurora/admin/BUILD > 22bf3f9943ea11258ba681bdb80feb00206bb926 > src/main/python/apache/aurora/admin/aurora_admin.py > 1c39717b656465bb1966073340f9fe80be01a085 > src/main/python/apache/aurora/client/BUILD > e73cd52289209bb9658b16bb77dc0b0a9c811a1a > src/main/python/apache/aurora/client/api/BUILD > a030a67b78fc4bc4682d0df169e27efc6810dce3 > src/main/python/apache/aurora/client/cli/BUILD > 973d05971bd940c7e38c48ce6bfbf5c8e1654c5a > src/main/python/apache/aurora/client/cli/client.py > c0974f3bef59f8f7c2320398d367cb4dd9048d2b > src/main/python/apache/aurora/client/hooks/BUILD > ddf813b5d2e7d63507a8e08745ebf6cb3dbac8e1 > src/main/python/apache/aurora/common/BUILD > abc122b0775bb17b1df67bdb946c472010219b9b > src/main/python/apache/aurora/common/auth/BUILD > 0abac94eeeb71e6af43ed191ea690e5f96a6be23 > src/main/python/apache/aurora/common/auth/kerberos.py > 2d782b63b611a9d2604ef0ab1116d3e68fb86dc7 > src/main/python/apache/aurora/config/BUILD > 0a3a93fa6bb785903f71bc067aecc79c0e45a0b5 > src/main/python/apache/aurora/config/schema/BUILD > 171f42a24ec7ddc2846eb68b6a60e7d8dec4383b > src/main/python/apache/aurora/executor/BUILD > 891cbe63d23ea59a68ca99f62d29be5713c9b91d > src/main/python/apache/aurora/executor/bin/BUILD > b23429ab9d1d3db1af2bb1b77f5bce30de19f34b > src/main/python/apache/aurora/executor/common/BUILD > 3d94792b9e3c2d0f7bb7ce42616f08947f5119ee > src/main/python/apache/aurora/kerberos/BUILD PRE-CREATION > src/main/python/apache/aurora/tools/BUILD > 9dfeb6c7e5a3796c76250aa9ff6fd4230d00cfb0 > src/main/python/apache/thermos/BUILD > 8221aa0bd4efe5f519550cba716d6a564ba9ae44 > src/main/python/apache/thermos/bin/BUILD > 4f0cb9b67b1c3c52ec3278ce92ff0d765257796c > src/main/python/apache/thermos/bin/__init__.py > src/main/python/apache/thermos/bin/thermos_ckpt.py > 8ed69e0440b6aec85c5fa9e138215b592e9adcb1 > src/main/python/apache/thermos/bin/thermos_runner.py > src/main/python/apache/thermos/cli/BUILD > 2b9bc6245718397e4cb1ba104194b167434a3112 > src/main/python/apache/thermos/cli/bin/BUILD > f33c7f838a6a0932abc737d0ecf7ca3a59580e2e > src/main/python/apache/thermos/cli/bin/thermos.py > fcef38d33e7ca2005f35c3bdb90ffee6aeade3af > src/main/python/apache/thermos/cli/commands/BUILD > 552eeb4f61693033d8828e789bd22e680b957d1d > src/main/python/apache/thermos/common/BUILD > 942fc15f5a5d6a5ff58385b10f3783ac476a4f82 > src/main/python/apache/thermos/config/BUILD > d9099c5806eadb1190d2028142a7ec711023d39f > src/main/python/apache/thermos/config/bin/config_load.py > d6e1f820ac6b0fa4e47e26f99df1602a2d3d021e > src/main/python/apache/thermos/config/bin/config_repl.py > ae9ca3b2812f719b0a6185081434d557492ac825 > src/main/python/apache/thermos/core/BUILD > d47b7a2c5db8ba9a85e2403b7d6bf2dea3f045ea > src/main/python/apache/thermos/monitoring/BUILD > e8851026cb7ff59f0fd719837fdb0110be356c31 > src/main/python/apache/thermos/observer/BUILD > 41db2cc2e11234c434f58f55abec0b9f308096be > src/main/python/apache/thermos/observer/bin/BUILD > 0abe2ccfe9c5ccb509ad731125385900114ba352 > src/main/python/apache/thermos/observer/bin/__init__.py > src/main/python/apache/thermos/observer/bin/thermos_observer.py > 39d3994a6163746e853cd21fc4c3585edc2b54cb > src/main/python/apache/thermos/observer/http/BUILD > 0bd770453dc78b043c9e6171dc7439da19c5872e > src/main/python/apache/thermos/testing/BUILD > 8b5f6dc93c95e2f69d1b755e93b5f24dec0ead30 > src/test/python/apache/aurora/BUILD > c2251ce4768b9bc9d4c4f6869bddcb23f0f6f986 > src/test/python/apache/aurora/admin/BUILD > 69da2c97cb08025a27ca276bb2ad6fcc43db1b10 > src/test/python/apache/aurora/client/BUILD > c55adfe9825b77f418e41fa9a4ba43926bd991ed > src/test/python/apache/aurora/client/api/BUILD > 65b378b0b4c5fa11f9899ef04a4a10a211f37245 > src/test/python/apache/aurora/client/cli/BUILD > 0d85f5fba9d19ae0e9c36546f130b93664b4f6de > src/test/python/apache/aurora/client/hooks/BUILD > 0b924ccfbcdb4800f99b80067ff8a78252f99907 > src/test/python/apache/aurora/common/BUILD > 9b1d4d876e10cb759202240931e4787ce673d897 > src/test/python/apache/aurora/config/BUILD > c85e998e66a989bb3e2ad8b9aab03702f33c0ef9 > src/test/python/apache/aurora/executor/BUILD > 8fff66ef8858af892ba1124454fefb07715943d7 > src/test/python/apache/aurora/executor/bin/BUILD > 713ce9529e36c70e1dde17a724efe7631c7aca4c > src/test/python/apache/aurora/executor/common/BUILD > b3da27bb83c44a228851b256cc09f093d1e2eb87 > src/test/python/apache/aurora/executor/test_thermos_executor.py > c3baa9f4b9bfbfa3ab4eb8ab4d74d49c49b6b057 > src/test/python/apache/aurora/executor/test_thermos_task_runner.py > cc326562db59eee807b22c4ee16d753abb3c6468 > src/test/python/apache/thermos/cli/BUILD > 087b1740de4d8a30c74c7776eb83f9784e0049cc > src/test/python/apache/thermos/cli/commands/BUILD > 5465b19be5ab8bdf7252e7b1fa7a4ef95063193d > src/test/python/apache/thermos/common/BUILD > bb70867e0e070ee9651f018f30990bd9ff0dd88f > src/test/python/apache/thermos/config/BUILD > a06af36c83fc7ec00ecd00df7e424faae3118131 > src/test/python/apache/thermos/core/BUILD > d637c24f098468776fb8b0758f5990b83ec362c5 > src/test/python/apache/thermos/monitoring/BUILD > f4ad7fc1245980ef727c7c4a30af89b2d8d1293a > src/test/python/apache/thermos/observer/BUILD > ff92a52fe7a88379e8aa1c1b2385c065bd375a68 > src/test/python/apache/thermos/observer/http/BUILD > 0cdaafc3e71d21d48c35e0dac68910c53d003fae > > Diff: https://reviews.apache.org/r/36972/diff/ > > > Testing > ------- > > ./pants test.pytest --no-fast src/test/python:: > ./build-support/python/make-python-sdists > ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh > > Manually checked that `thermos status` works. > > I don't have a test environment for the debian package or the spec file. > > Documentation pushed to > https://github.com/kevints/aurora/blob/36972/docs/build-system.md > > > Thanks, > > Kevin Sweeney > >
