-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37141/#review94306
-----------------------------------------------------------


Master (8a8ed2d) is red with this patch.
  ./build-support/jenkins/build.sh

:testClasses
:checkstyleTest
:findbugsJmh
:findbugsMain
:findbugsTest
:licenseJmh UP-TO-DATE
:licenseMain UP-TO-DATE
:licenseTest UP-TO-DATE
:license UP-TO-DATE
:pmdMain
:test

org.apache.aurora.scheduler.storage.mem.StorageTransactionTest > testOperations 
FAILED
    java.lang.Exception at StorageTransactionTest.java:128
        Caused by: java.lang.AssertionError at StorageTransactionTest.java:128

org.apache.aurora.scheduler.storage.mem.StorageTransactionTest > 
testWritesUnderTransaction FAILED
    java.lang.Exception at StorageTransactionTest.java:159
        Caused by: java.lang.AssertionError at StorageTransactionTest.java:159

913 tests completed, 2 failed, 3 skipped
:test FAILED
:jacocoTestReport
Coverage report generated: 
file:///home/jenkins/jenkins-slave/workspace/AuroraBot/dist/reports/jacoco/test/html/index.html
:analyzeReport
Instruction coverage of 0.8948179185408836 exceeds minimum coverage of 0.89.
Branch coverage is 0.8198814409484724, but must be greater than 0.835

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':test'.
> There were failing tests. See the report at: 
> file:///home/jenkins/jenkins-slave/workspace/AuroraBot/dist/reports/tests/index.html

* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug 
option to get more log output.

BUILD FAILED

Total time: 4 mins 18.79 secs


I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On Aug. 5, 2015, 8:51 p.m., Bill Farner wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37141/
> -----------------------------------------------------------
> 
> (Updated Aug. 5, 2015, 8:51 p.m.)
> 
> 
> Review request for Aurora and Maxim Khutornenko.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> This additional `@Transactional` renders the inner transaction useless, and 
> results in async work still being performed within the transaction.
> 
> I neglected to remove this in https://reviews.apache.org/r/37049/, and also 
> neglected to validate that patch against the environment where i've been able 
> to trigger the issue.  With this patch, the `IllegalArgumentException` is 
> fixed.
> 
> 
> Diffs
> -----
> 
>   src/main/java/org/apache/aurora/scheduler/storage/db/DbStorage.java 
> aac62e2bbc212f61e61ffca75753ef06f1701ea4 
> 
> Diff: https://reviews.apache.org/r/37141/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Bill Farner
> 
>

Reply via email to