----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37141/ -----------------------------------------------------------
(Updated Aug. 7, 2015, 1:35 p.m.) Review request for Aurora and Maxim Khutornenko. Changes ------- Updated to include proper handling of reentrant calls to `DbStorage#write()`. Summary (updated) ----------------- DbStorage: avoid flushing for reentrant writes, remove extra @Transactional. Bugs: AURORA-1395 https://issues.apache.org/jira/browse/AURORA-1395 Repository: aurora Description (updated) ------- Two loose ends from r/37049: - An extra @Transactional which rendered the inner transaction useless, and results in async work still being performed within the transaction. - No handling for reentrant calls to write(), causing async work to be flushed in inner calls and before the transaction actually completes. Diffs (updated) ----- src/main/java/org/apache/aurora/scheduler/storage/db/DbStorage.java aac62e2bbc212f61e61ffca75753ef06f1701ea4 src/test/java/org/apache/aurora/scheduler/storage/db/DbStorageTest.java 3b05db9481edc7a82c0823cf50793c7d12384541 Diff: https://reviews.apache.org/r/37141/diff/ Testing ------- Thanks, Bill Farner