----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37153/ -----------------------------------------------------------
(Updated Aug. 11, 2015, 12:54 a.m.) Review request for Aurora and Bill Farner. Changes ------- Simplifying the Resources interface by moving toResourceList() into ResourceSlot. This makes Resources serve only as a Mesos resource wrapper, while ResourceSlot handles all cases where resource traits are already identified. Contemplated for awhile whether to make this change a separate diff but decided doing it now makes a far cleaner logical split after all. Repository: aurora Description ------- This reverses ResourceSlot->Resources relationship making ResourceSlot an anonymous representation of the Resources class. ResourceSlot is now used for calculations and when Mesos resource traits are irrelevant. There is some redundancy between Resources and ResourceSlot (i.e. how resource vector is stored) that will be eliminated once Resouces starts using Mesos resource vector (Iterable<Resource>). Will not apply cleanly as it branched off of 37144. Diffs (updated) ----- src/jmh/java/org/apache/aurora/benchmark/Offers.java 269c196cedb7e4ebd1f8a9994f78619828a21afb src/main/java/org/apache/aurora/scheduler/ResourceSlot.java e10656b7a55de790df599ef792f4e76f3f6fdfd1 src/main/java/org/apache/aurora/scheduler/ResourceType.java PRE-CREATION src/main/java/org/apache/aurora/scheduler/Resources.java e38024506df3c0293a0d70def0e8ca5adc3ed6a2 src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java 102069ab0cbe3198e12f13a4381c292e3cfe0d8b src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilterImpl.java 08d7ac70653359bcdddb0405575381a8cb867a2f src/main/java/org/apache/aurora/scheduler/mesos/ExecutorSettings.java 44011f8b3107831016ef140f58821e92eb7d07c0 src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java c160a530a20e8e0dd29dda97ce58044c6f8e07e1 src/main/java/org/apache/aurora/scheduler/preemptor/PreemptionVictim.java 8d2f069c7a99a8108308013d0a9458af34111fa8 src/main/java/org/apache/aurora/scheduler/preemptor/PreemptionVictimFilter.java 429341523f131a4812d37c77962b9c25f8dd9e53 src/main/java/org/apache/aurora/scheduler/state/TaskAssigner.java 14d70df1f86e87ccc299558326b69662af759d08 src/main/java/org/apache/aurora/scheduler/stats/AsyncStatsModule.java 81b1640d7ca1c85c1078282ef414e177c278678f src/test/java/org/apache/aurora/scheduler/ResourceSlotTest.java d1294e238385c4cb060351b7cca6cd6700ada0a3 src/test/java/org/apache/aurora/scheduler/ResourcesTest.java 8bc56b26d3481b7ce456e6a1a91b4ff6c8010bb6 src/test/java/org/apache/aurora/scheduler/app/SchedulerIT.java 8d8f8a26fe341713953cfc5897cf6744dfb48f05 src/test/java/org/apache/aurora/scheduler/app/local/simulator/ClusterSimulatorModule.java 24278ba76f9b5f172ea4582a8ad4eb63100b5f9b src/test/java/org/apache/aurora/scheduler/events/NotifyingSchedulingFilterTest.java abbc8e34ed2a02d22c4c82cea6e1b69311d80754 src/test/java/org/apache/aurora/scheduler/filter/SchedulingFilterImplTest.java 6441ffdd0d04314d8b45cbed81fce07e3762a740 src/test/java/org/apache/aurora/scheduler/mesos/MesosTaskFactoryImplTest.java c74cc7f94c50e97f8fea50ef128b98d9d313fcfa src/test/java/org/apache/aurora/scheduler/mesos/Offers.java e29829db3eb7d48b03418b6765d280d81512844c src/test/java/org/apache/aurora/scheduler/mesos/TaskExecutors.java 14820f212b599157c90445d05e3164bbc7eccd94 src/test/java/org/apache/aurora/scheduler/preemptor/PreemptionVictimFilterTest.java 4bae195ea9b2e9bc166a2a4ba370888cdca283d5 src/test/java/org/apache/aurora/scheduler/state/TaskAssignerImplTest.java 1de1d1f11a57ac6f31f184d57776bc0d0256a901 Diff: https://reviews.apache.org/r/37153/diff/ Testing ------- Thanks, Maxim Khutornenko
