-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37365/#review95094
-----------------------------------------------------------
Master (cbc42c4) is red with this patch.
./build-support/jenkins/build.sh
src.test.python.apache.aurora.client.api.updater_util
..... SUCCESS
src.test.python.apache.aurora.client.base
..... SUCCESS
src.test.python.apache.aurora.client.binding_helper
..... SUCCESS
src.test.python.apache.aurora.client.cli.api
..... SUCCESS
src.test.python.apache.aurora.client.cli.client
..... SUCCESS
src.test.python.apache.aurora.client.cli.command_hooks
..... SUCCESS
src.test.python.apache.aurora.client.cli.config
..... SUCCESS
src.test.python.apache.aurora.client.cli.context
..... SUCCESS
src.test.python.apache.aurora.client.cli.cron
..... SUCCESS
src.test.python.apache.aurora.client.cli.inspect
..... SUCCESS
src.test.python.apache.aurora.client.cli.job
..... SUCCESS
src.test.python.apache.aurora.client.cli.options
..... SUCCESS
src.test.python.apache.aurora.client.cli.plugins
..... SUCCESS
src.test.python.apache.aurora.client.cli.quota
..... SUCCESS
src.test.python.apache.aurora.client.cli.sla
..... SUCCESS
src.test.python.apache.aurora.client.cli.supdate
..... FAILURE
src.test.python.apache.aurora.client.cli.task
..... SUCCESS
src.test.python.apache.aurora.client.config
..... SUCCESS
src.test.python.apache.aurora.client.hooks.non_hooked_api
..... SUCCESS
src.test.python.apache.aurora.common.test_aurora_job_key
..... SUCCESS
src.test.python.apache.aurora.common.test_cluster
..... SUCCESS
src.test.python.apache.aurora.common.test_cluster_option
..... SUCCESS
src.test.python.apache.aurora.common.test_clusters
..... SUCCESS
src.test.python.apache.aurora.common.test_http_signaler
..... SUCCESS
src.test.python.apache.aurora.common.test_pex_version
..... SUCCESS
src.test.python.apache.aurora.common.test_shellify
..... SUCCESS
src.test.python.apache.aurora.common.test_transport
..... SUCCESS
src.test.python.apache.aurora.executor.common.path_detector
..... SUCCESS
src.test.python.apache.aurora.executor.common.task_info
..... SUCCESS
src.test.python.apache.thermos.cli.commands.commands
..... SUCCESS
src.test.python.apache.thermos.cli.common
..... SUCCESS
src.test.python.apache.thermos.cli.main
..... SUCCESS
src.test.python.apache.thermos.common.test_pathspec
..... SUCCESS
src.test.python.apache.thermos.core.test_runner_integration
..... SUCCESS
src.test.python.apache.thermos.monitoring.test_disk
..... SUCCESS
FAILURE
[31m
FAILURE[0m
I will refresh this build result if you post a review containing "@ReviewBot
retry"
- Aurora ReviewBot
On Aug. 12, 2015, 3:29 p.m., Joshua Cohen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37365/
> -----------------------------------------------------------
>
> (Updated Aug. 12, 2015, 3:29 p.m.)
>
>
> Review request for Aurora, David McLaughlin and Maxim Khutornenko.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Add a new UI page to show all tasks (active and completed) for a specific
> instance id.
>
> N.B.: changes to controllers.js look significant, but it's 90% refactoring so
> that JobController and JobInstanceController can reuse common code.
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/client/base.py
> dee4c28a26828912bec073c7e5213a03c9703eee
> src/main/resources/scheduler/assets/breadcrumb.html
> 13147935c3c28680d5decd1e03e40d9cf04aaed3
> src/main/resources/scheduler/assets/css/app.css
> a4735efe58a09a46f2b95ebe98f219cb9e7ee27d
> src/main/resources/scheduler/assets/instance.html PRE-CREATION
> src/main/resources/scheduler/assets/job.html
> 942635a61132bb9a38a6faf3f8fe046e6bcabd95
> src/main/resources/scheduler/assets/js/app.js
> b66409f628046c67b62c92a75cbeed20c09b4ec1
> src/main/resources/scheduler/assets/js/controllers.js
> 04ea1cb6998af7c238eb2fd1a7d05a9663abc56c
> src/main/resources/scheduler/assets/js/services.js
> a514fa7da3c049e1f5a3e49263a82cf2c28d1b2d
> src/main/resources/scheduler/assets/taskInstance.html PRE-CREATION
> src/test/python/apache/aurora/client/test_base.py
> 1a560088279ac945cce14d02454e50b8483771e4
>
> Diff: https://reviews.apache.org/r/37365/diff/
>
>
> Testing
> -------
>
> - ./gradlew jsHint
> - ./pants test src/test/python/apache/aurora/client:base
> - Verified update page url in client was correct in Vagrant.
> - See attached screenshot for an example of what the instance page looks like.
>
>
> File Attachments
> ----------------
>
> Example of instance page in action.
>
> https://reviews.apache.org/media/uploaded/files/2015/08/11/2ab72f9d-9e60-4b86-b971-b6aba5465def__Screen_Shot_2015-08-11_at_4.53.07_PM.png
>
>
> Thanks,
>
> Joshua Cohen
>
>
