> On Aug. 14, 2015, 4:11 p.m., Joshua Cohen wrote:
> > src/main/java/org/apache/aurora/scheduler/Resources.java, line 187
> > <https://reviews.apache.org/r/37366/diff/1/?file=1037844#file1037844line187>
> >
> >     nit: any reason this declaration was moved after it's usage?

Just trying to make it consistent with ResourceSlot and some other places where 
we declare private functions. Moving them out of the way helps readability IMO.


- Maxim


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37366/#review95431
-----------------------------------------------------------


On Aug. 13, 2015, 9:46 p.m., Maxim Khutornenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37366/
> -----------------------------------------------------------
> 
> (Updated Aug. 13, 2015, 9:46 p.m.)
> 
> 
> Review request for Aurora, Joshua Cohen and Zameer Manji.
> 
> 
> Bugs: AURORA-1415
>     https://issues.apache.org/jira/browse/AURORA-1415
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Converting `Resources` into Mesos resource container, adding coverage and 
> introducing `filter()` method.
> 
> Further progress on `filter()` is blocked until we upgrade to Mesos 0.23.0.
> 
> Will not apply cleanly, diffed against 37153.
> 
> 
> Diffs
> -----
> 
>   src/main/java/org/apache/aurora/scheduler/Resources.java 
> e38024506df3c0293a0d70def0e8ca5adc3ed6a2 
>   src/main/java/org/apache/aurora/scheduler/state/TaskAssigner.java 
> 14d70df1f86e87ccc299558326b69662af759d08 
>   src/test/java/org/apache/aurora/scheduler/ResourceSlotTest.java 
> d1294e238385c4cb060351b7cca6cd6700ada0a3 
>   src/test/java/org/apache/aurora/scheduler/ResourcesTest.java 
> 8bc56b26d3481b7ce456e6a1a91b4ff6c8010bb6 
> 
> Diff: https://reviews.apache.org/r/37366/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>

Reply via email to