> On Aug. 21, 2015, 12:35 a.m., Zameer Manji wrote:
> > Don't forget to create tickets about documenting this flag.

Good point. Created a general feature doc ticket.


> On Aug. 21, 2015, 12:35 a.m., Zameer Manji wrote:
> > src/main/java/org/apache/aurora/scheduler/mesos/CommandLineDriverSettingsModule.java,
> >  line 80
> > <https://reviews.apache.org/r/37663/diff/1/?file=1045466#file1045466line80>
> >
> >     You might want to put a warning comment about the consequences of 
> > enabling this and point to MESOS-703.

I was assured by Mesos folks that the core problem in MESOS-703 has been fixed 
as of 0.23. I'll defer any warning comments until the feature enters 
integration phase and I am able to verify this in Vagrant.


- Maxim


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37663/#review96017
-----------------------------------------------------------


On Aug. 21, 2015, 12:04 a.m., Maxim Khutornenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37663/
> -----------------------------------------------------------
> 
> (Updated Aug. 21, 2015, 12:04 a.m.)
> 
> 
> Review request for Aurora and Zameer Manji.
> 
> 
> Bugs: AURORA-1419
>     https://issues.apache.org/jira/browse/AURORA-1419
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> The revocable capability is behind a new command flag and is not set by 
> default.
> 
> 
> Diffs
> -----
> 
>   
> src/main/java/org/apache/aurora/scheduler/mesos/CommandLineDriverSettingsModule.java
>  54608c8f819b65186ea0d000fc01b9538d5cb4ee 
>   
> src/test/java/org/apache/aurora/scheduler/mesos/CommandLineDriverSettingsModuleTest.java
>  9e176882246b48ac87bf35c77ac8c449a0a53352 
> 
> Diff: https://reviews.apache.org/r/37663/diff/
> 
> 
> Testing
> -------
> 
> ./gradlew -Pq build
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>

Reply via email to