> On Aug. 24, 2015, 3:07 p.m., Kevin Sweeney wrote: > > build-artifact.sh, line 30 > > <https://reviews.apache.org/r/37731/diff/1/?file=1048757#file1048757line30> > > > > For the RPM spec consider making this argument an explicit command-line > > flag (with `--define`) rather than an environment variable. > > Bill Farner wrote: > That's what's done, but the Makefile consumes it as an env var: > https://github.com/apache/aurora-packaging/blob/master/specs/rpm/Makefile#L57 > > Bill Farner wrote: > Scratch that, the Makefile reads `.auroraversion`. Updated patch > incoming to allow override via env var to the Makefile. > > Bill Farner wrote: > Last edit - it uses `?=`, so no change needed.
Not necessary to read the environment variable within the Makefile - you can call it with make `AURORA_VERSION=$AURORA_VERSION` ... - Kevin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37731/#review96221 ----------------------------------------------------------- On Aug. 24, 2015, 3:02 p.m., Bill Farner wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/37731/ > ----------------------------------------------------------- > > (Updated Aug. 24, 2015, 3:02 p.m.) > > > Review request for Aurora and Kevin Sweeney. > > > Bugs: AURORA-1410 > https://issues.apache.org/jira/browse/AURORA-1410 > > > Repository: aurora-packaging > > > Description > ------- > > This allows the builder to set the aurora version number. The > `AURORA_VERSION` environment variable is already read by the RPM spec. > > > Diffs > ----- > > README.md e45f22fed3a7a6d04db08481d2d87bf22ebfdd1a > build-artifact.sh e6ea723331db34e8d0e8462c7cdbf66ec4d4814e > builder/deb/ubuntu-trusty/build.sh 6bee0e7bd7fe81682b583041cf9ae32bfaec33f0 > > Diff: https://reviews.apache.org/r/37731/diff/ > > > Testing > ------- > > ``` > ./build-artifact.sh \ > builder/deb/ubuntu-trusty \ > ~/Downloads/apache-aurora-0.9.0.tar.gz \ > 0.9.0 > ``` > > > Thanks, > > Bill Farner > >
