> On Aug. 24, 2015, 8:57 p.m., Zameer Manji wrote: > > api/src/main/thrift/org/apache/aurora/gen/api.thrift, line 255 > > <https://reviews.apache.org/r/37719/diff/1/?file=1048455#file1048455line255> > > > > Will this attribute be required in the future? > > Maxim Khutornenko wrote: > Absolutely. Otherwise, how will users specify their tier? We have debated > using env as a replacement but there are just too many drawbacks with it. See > "alernative solution" at the end of design doc: > https://docs.google.com/document/d/1r1WCHgmPJp5wbrqSZLsgtxPNj3sULfHrSFmxp2GyPTo > > Bill Farner wrote: > I'm a -1 to requiring it via the API. There are plenty of valid use > cases where there are not multiple tier definitions, and i would like to > support a minimal input over the API for those scenarios. > > However, we can continue this discussion when the time is right. > > Maxim Khutornenko wrote: > Not sure I understand your proposal. How will users instruct Aurora to > use a specific tier without this change?
I'm advocating for `tier` to always be optional via the scheduler API. - Bill ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37719/#review96199 ----------------------------------------------------------- On Aug. 24, 2015, 9:21 p.m., Maxim Khutornenko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/37719/ > ----------------------------------------------------------- > > (Updated Aug. 24, 2015, 9:21 p.m.) > > > Review request for Aurora, Bill Farner and Zameer Manji. > > > Bugs: AURORA-1414 > https://issues.apache.org/jira/browse/AURORA-1414 > > > Repository: aurora > > > Description > ------- > > Added support for 'tier' in schema and thrift. > > > Diffs > ----- > > api/src/main/thrift/org/apache/aurora/gen/api.thrift > f792be0ad393072b4a4ec525363e06cfd16b63d0 > src/main/java/org/apache/aurora/scheduler/TierManager.java > ebfad9788a65fbfb7790e40db4a47a6a570b4a7b > src/main/java/org/apache/aurora/scheduler/base/TaskTestUtil.java > 1903315c0753c68fd1e103d48fff037ba59b7642 > > src/main/java/org/apache/aurora/scheduler/configuration/ConfigurationManager.java > d103d19b30c5e219c385018d26d6872464520380 > > src/main/java/org/apache/aurora/scheduler/storage/db/views/DbTaskConfig.java > 956c508b163cadb13858f7ac0fbc7a971c2cc770 > src/main/python/apache/aurora/client/config.py > 59703ef18c61dbed635954e05a38385ac364b679 > src/main/python/apache/aurora/config/schema/base.py > 214d5594a2c22e92d5412e40c2ddf18e65c2af63 > src/main/python/apache/aurora/config/thrift.py > adf53bb1c28d61e9bcb670c60f293cf8262c5836 > > src/main/resources/org/apache/aurora/scheduler/storage/db/TaskConfigMapper.xml > bfad339a84c6ca87bc6fea339af10a559d8eb3d5 > src/main/resources/org/apache/aurora/scheduler/storage/db/schema.sql > 7634047abaec9129ee9ead08cc51a10b3261515d > src/test/java/org/apache/aurora/scheduler/TierManagerTest.java > 37e19ac71b0f1da7b8a0c06137e43d2143302d85 > > src/test/java/org/apache/aurora/scheduler/configuration/ConfigurationManagerTest.java > b231827ff7fdb2aa37580a32cae74d5da17c2f97 > src/test/python/apache/aurora/client/cli/test_create.py > 69039b6c0504c9d14a96693249c7199958aadc96 > src/test/python/apache/aurora/client/test_config.py > 986061bf0829caa0509416a3de1778c2fa40a766 > src/test/python/apache/aurora/config/test_thrift.py > 061864eb475807332d328fa72f35f179d36ef9e8 > > Diff: https://reviews.apache.org/r/37719/diff/ > > > Testing > ------- > > ./gradlew -Pq build > ./pants test.pytest --no-fast src/test/python:: > ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh > > > Thanks, > > Maxim Khutornenko > >
