-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37742/#review96286
-----------------------------------------------------------



src/test/sh/org/apache/aurora/e2e/http/http_example.aurora 
<https://reviews.apache.org/r/37742/#comment151617>

    I am a bit concerned we will no longer have any constraint coverage in our 
e2e tests. Can you clarify why post deploy RPM env altering is not an option 
here?


- Maxim Khutornenko


On Aug. 25, 2015, 1:11 a.m., Bill Farner wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37742/
> -----------------------------------------------------------
> 
> (Updated Aug. 25, 2015, 1:11 a.m.)
> 
> 
> Review request for Aurora and Maxim Khutornenko.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> These are no longer needed now that the scheduler isn't injecting these 
> settings by default for jobs.  It's beneficial for them to be removed, as it 
> will make it easier to point the e2e test at an arbitrary environment to 
> exercise it.  I would like to use that approach to test RPMs/debs.
> 
> 
> Diffs
> -----
> 
>   examples/vagrant/upstart/mesos-slave.conf 
> 2b6a60673fc0a7ea3b73471701cd5d3efd6ce639 
>   src/test/sh/org/apache/aurora/e2e/http/http_example.aurora 
> c1a10d8ea60be6aa56e4517fb34288d7d5ae1480 
>   src/test/sh/org/apache/aurora/e2e/http/http_example_docker.aurora 
> 870b3e68035fdf86253cf9b92b606645134b3369 
>   src/test/sh/org/apache/aurora/e2e/http/http_example_docker_updated.aurora 
> e55aad3a58d4e3c19332e06b70771f51f07aa9b7 
>   src/test/sh/org/apache/aurora/e2e/http/http_example_updated.aurora 
> 423dd4d4e8b03c2f852e25acd9340bd6288b7d24 
> 
> Diff: https://reviews.apache.org/r/37742/diff/
> 
> 
> Testing
> -------
> 
> e2e tests pass
> 
> 
> Thanks,
> 
> Bill Farner
> 
>

Reply via email to