> On Aug. 26, 2015, 5:39 p.m., Maxim Khutornenko wrote:
> > src/test/python/apache/aurora/config/test_thrift.py, line 177
> > <https://reviews.apache.org/r/37801/diff/1/?file=1053308#file1053308line177>
> >
> >     Would be great to have a non-empty hostname as well to explicitly 
> > assert its value.

Is there a good way to test this other than something gross like: 
str(String("{{mesos.hostname}}").bind(*instance.scopes())).  Here the hostname 
is in the binding context but not on any inspectable field on the instance 
itself.


- Steve


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37801/#review96560
-----------------------------------------------------------


On Aug. 26, 2015, 5:05 p.m., Steve Niemitz wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37801/
> -----------------------------------------------------------
> 
> (Updated Aug. 26, 2015, 5:05 p.m.)
> 
> 
> Review request for Aurora.
> 
> 
> Bugs: AURORA-1261
>     https://issues.apache.org/jira/browse/AURORA-1261
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Added support for {{mesos.hostname}} in aur files
> 
> 
> Diffs
> -----
> 
>   src/main/python/apache/aurora/config/schema/base.py 
> d1f1e4f8082553f3a773e70a7f5cd0c48181ae8c 
>   src/main/python/apache/aurora/config/thrift.py 
> 88dd1c7cf2e5a9bfbe827bc342d49f7a18bc8558 
>   src/main/python/apache/aurora/executor/common/task_info.py 
> 082947548d8d8e0eaf2ee4807636f50237e0ce22 
>   src/test/python/apache/aurora/config/test_base.py 
> 5a58dd0f072889a850153841f972dcca4d3c913b 
>   src/test/python/apache/aurora/config/test_thrift.py 
> f48ac88c076c12541626b497ca4fc47e5941dd31 
> 
> Diff: https://reviews.apache.org/r/37801/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Steve Niemitz
> 
>

Reply via email to