> On Aug. 26, 2015, 11:18 a.m., Maxim Khutornenko wrote:
> > Any noticable impact on JobDetailsBenchmark after this change?

Thanks for the nudge - turns out this patch broke that test due to schema 
requirements.  Fixed, and will put results in the testing field.


> On Aug. 26, 2015, 11:18 a.m., Maxim Khutornenko wrote:
> > src/main/resources/org/apache/aurora/scheduler/storage/db/schema.sql, line 
> > 194
> > <https://reviews.apache.org/r/37789/diff/1/?file=1053036#file1053036line194>
> >
> >     kill newline

Done.


- Bill


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37789/#review96563
-----------------------------------------------------------


On Aug. 25, 2015, 11:41 p.m., Bill Farner wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37789/
> -----------------------------------------------------------
> 
> (Updated Aug. 25, 2015, 11:41 p.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Maxim Khutornenko.
> 
> 
> Bugs: AURORA-647
>     https://issues.apache.org/jira/browse/AURORA-647
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Unfortunately the reference forced me to move the location of tables in 
> schema.sql, making the delta look much bigger there.
> 
> 
> Diffs
> -----
> 
>   src/main/java/org/apache/aurora/scheduler/storage/db/DbJobUpdateStore.java 
> 7728684560d3111edaa2e29d9738f71bc1d7a9ff 
>   
> src/main/java/org/apache/aurora/scheduler/storage/db/JobUpdateDetailsMapper.java
>  02ea355539d6f56c1c861ac83293b649285f43f4 
>   
> src/main/java/org/apache/aurora/scheduler/storage/db/typehandlers/TaskConfigTypeHandler.java
>  2f58357dd63c46eb69de6a6daedcf027712d7b2e 
>   
> src/main/java/org/apache/aurora/scheduler/storage/db/typehandlers/TypeHandlers.java
>  9afc3f3fcdcc1b60af2207888993411a55984c8e 
>   
> src/main/java/org/apache/aurora/scheduler/storage/db/views/DbInstanceTaskConfig.java
>  PRE-CREATION 
>   src/main/java/org/apache/aurora/scheduler/storage/db/views/DbJobUpdate.java 
> PRE-CREATION 
>   
> src/main/java/org/apache/aurora/scheduler/storage/db/views/DbJobUpdateDetails.java
>  PRE-CREATION 
>   
> src/main/java/org/apache/aurora/scheduler/storage/db/views/DbJobUpdateInstructions.java
>  PRE-CREATION 
>   
> src/main/java/org/apache/aurora/scheduler/storage/db/views/DbStoredJobUpdateDetails.java
>  PRE-CREATION 
>   
> src/main/resources/org/apache/aurora/scheduler/storage/db/JobUpdateDetailsMapper.xml
>  6ffb54f5beef332097fd5c2390b56873a82f0aa9 
>   src/main/resources/org/apache/aurora/scheduler/storage/db/schema.sql 
> d971aa19982e6095fbf514714df670cabd523d9d 
>   
> src/test/java/org/apache/aurora/scheduler/storage/db/DbJobUpdateStoreTest.java
>  3e78c097a7a9252ded8a4a7fc6609ecf5d61c5b5 
> 
> Diff: https://reviews.apache.org/r/37789/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Bill Farner
> 
>

Reply via email to