----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38010/#review97310 -----------------------------------------------------------
Master (5a7bd34) is green with this patch. ./build-support/jenkins/build.sh However, it appears that it might lack test coverage. I will refresh this build result if you post a review containing "@ReviewBot retry" - Aurora ReviewBot On Sept. 1, 2015, 5:29 p.m., Joshua Cohen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38010/ > ----------------------------------------------------------- > > (Updated Sept. 1, 2015, 5:29 p.m.) > > > Review request for Aurora, David McLaughlin and Bill Farner. > > > Repository: aurora > > > Description > ------- > > Stop in-progress instances from pulsing when update has been aborted. > > Also removed the "INSTANCE-" prefix from tooltip as it seemed superfluous and > added "ABORTED" to the tooltip for instances that were "UPDATING" when the > update was aborted. An argument can be made for adding "ABORTED" to the > tooltip for all non-terminal states (PENDING, etc.), let me know if you think > we should add it for those as well. > > > Diffs > ----- > > src/main/resources/scheduler/assets/css/app.css > 9437c53e695d1c4009d9df5fb23e34479f5b3d2d > src/main/resources/scheduler/assets/js/directives.js > d8f722c441b9399e7eacd6ae29966b3fb24a422d > src/main/resources/scheduler/assets/update.html > c8867093338593e5561e42fdee7cc5f15be0356e > > Diff: https://reviews.apache.org/r/38010/diff/ > > > Testing > ------- > > ./gradlew jshint > > Verified the pulsing stops for an aborted update. Also see screenshot for > tooltip changes. > > > File Attachments > ---------------- > > Screen Shot 2015-09-01 at 12.08.51 PM.png > > https://reviews.apache.org/media/uploaded/files/2015/09/01/340c71be-564f-4024-8ee3-bab960edfad0__Screen_Shot_2015-09-01_at_12.08.51_PM.png > > > Thanks, > > Joshua Cohen > >
