-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37956/#review97479
-----------------------------------------------------------

Ship it!


Ship It!

- Bill Farner


On Sept. 1, 2015, 9:03 a.m., Joshua Cohen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37956/
> -----------------------------------------------------------
> 
> (Updated Sept. 1, 2015, 9:03 a.m.)
> 
> 
> Review request for Aurora, David McLaughlin and Bill Farner.
> 
> 
> Bugs: AURORA-1345
>     https://issues.apache.org/jira/browse/AURORA-1345
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> The `true` parameter to `scope.$watch` tells Angular to only execute the 
> supplied function if the watched data has changed. Given our 15s polling 
> interval is likely less than time it takes for any progress to be made on an 
> update, this removes the majority of (no-op) DOM operations.
> 
> 
> Diffs
> -----
> 
>   src/main/resources/scheduler/assets/js/directives.js 
> d8f722c441b9399e7eacd6ae29966b3fb24a422d 
> 
> Diff: https://reviews.apache.org/r/37956/diff/
> 
> 
> Testing
> -------
> 
> Left tab open continually polling a job with ~3000 instances, confirmed that 
> memory usage did not grow beyond ~200MB.
> 
> 
> Thanks,
> 
> Joshua Cohen
> 
>

Reply via email to