> On Sept. 2, 2015, 9:53 a.m., Bill Farner wrote:
> > src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh, line 255
> > <https://reviews.apache.org/r/37926/diff/4-5/?file=1061209#file1061209line255>
> >
> >     What's being tested here?  Are you trying to determine whether the task 
> > executed correctly?  If so, maybe you should watch for it to enter RUNNING 
> > instead?
> 
> Maxim Khutornenko wrote:
>     This is our test equivalent of "aurora job create --wait-until=RUNNING". 
> It's actually more suitable for e2e purpose as it has timeout whereas 
> --wait-until blocks forever. This is especially important in view of bugs 
> like AURORA-1459 where tasks never reach RUNNING.
> 
> Bill Farner wrote:
>     Certainly a hack, but works for me - still better than the previous 
> iteration.

AFAIK, I added test_observer_ui to ensure the observer can load checkpoints for 
the task. I guess it also serves the `aurora job create --wait-until=RUNNING` 
case as well.


- Zameer


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37926/#review97480
-----------------------------------------------------------


On Sept. 2, 2015, 9:45 a.m., Maxim Khutornenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37926/
> -----------------------------------------------------------
> 
> (Updated Sept. 2, 2015, 9:45 a.m.)
> 
> 
> Review request for Aurora, Bill Farner and Zameer Manji.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Also, had to backout client tier validation added earlier until the feature 
> exits beta.
> 
> 
> Diffs
> -----
> 
>   examples/vagrant/upstart/aurora-scheduler.conf 
> e909451892f117e9e6eb80994079661827a0914c 
>   examples/vagrant/upstart/mesos-slave.conf 
> 2b6a60673fc0a7ea3b73471701cd5d3efd6ce639 
>   src/main/java/org/apache/aurora/scheduler/http/Offers.java 
> 4329ce10189df41a7a45cd6cc369333d7d5f65b0 
>   src/main/python/apache/aurora/client/config.py 
> f5ac084ae5b448221363add9476334742b217b92 
>   src/test/python/apache/aurora/client/test_config.py 
> 37459f5218e76fac831601806a0331927c0ee2c0 
>   src/test/sh/org/apache/aurora/e2e/http/http_example.aurora 
> c1a10d8ea60be6aa56e4517fb34288d7d5ae1480 
>   src/test/sh/org/apache/aurora/e2e/http/http_example_docker.aurora 
> 870b3e68035fdf86253cf9b92b606645134b3369 
>   src/test/sh/org/apache/aurora/e2e/http/http_example_docker_updated.aurora 
> e55aad3a58d4e3c19332e06b70771f51f07aa9b7 
>   src/test/sh/org/apache/aurora/e2e/http/http_example_updated.aurora 
> 423dd4d4e8b03c2f852e25acd9340bd6288b7d24 
>   src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh 
> 018efbe43de0c829799bc2f789958c55b1cb61a4 
> 
> Diff: https://reviews.apache.org/r/37926/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>

Reply via email to