-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38014/#review98116
-----------------------------------------------------------



commons/src/main/java/org/apache/aurora/common/application/AppLauncher.java 
(line 51)
<https://reviews.apache.org/r/38014/#comment154384>

    I removed the automatic inclusion of these two modules mostly because i 
moved LifecycleModule.  However, i'd like to remove AppLauncher in the near 
future, so i think this is fine.



src/main/java/org/apache/aurora/scheduler/app/LifecycleModule.java (line 1)
<https://reviews.apache.org/r/38014/#comment154383>

    The diff shows this as all new code, but it's a move that content tracking 
doesn't want to follow.


- Bill Farner


On Sept. 8, 2015, 4:21 p.m., Bill Farner wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38014/
> -----------------------------------------------------------
> 
> (Updated Sept. 8, 2015, 4:21 p.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Zameer Manji.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Remove StartupRegistry.
> 
> 
> Diffs
> -----
> 
>   commons/src/main/java/org/apache/aurora/common/application/AppLauncher.java 
> 78ed7d0aae50c976eba9045b17587258edc588b0 
>   
> commons/src/main/java/org/apache/aurora/common/application/StartupRegistry.java
>  997ee77dd8f6e02c2becddf98e16cbbbeec4cb4f 
>   
> commons/src/main/java/org/apache/aurora/common/application/StartupStage.java 
> 80509010f37894108881d40cad9d8ade8610f309 
>   
> commons/src/main/java/org/apache/aurora/common/application/modules/LifecycleModule.java
>  1b6bd086a5a434cb7e4b92ed9cfd252e2518ba66 
>   
> commons/src/main/java/org/apache/aurora/common/application/modules/StatsModule.java
>  3959ce3d688dd50399185925d91f0014fc1c43f9 
>   
> commons/src/main/java/org/apache/aurora/common/stats/TimeSeriesRepository.java
>  6928e48073d152915ca42b6f46236b21c0882086 
>   
> commons/src/main/java/org/apache/aurora/common/stats/TimeSeriesRepositoryImpl.java
>  387e379a9c84d663f2af23e4760754a023219860 
>   config/legacy_untested_classes.txt 4bae43a43d00f71456f37f001fcd21ce6a2fb841 
>   src/main/java/org/apache/aurora/scheduler/SchedulerServicesModule.java 
> 1077816b696c4d2e97aafa59900b6acf2adce064 
>   src/main/java/org/apache/aurora/scheduler/app/AppModule.java 
> 6892a70042e25fd672475517325b4e4b69a0adab 
>   src/main/java/org/apache/aurora/scheduler/app/LifecycleModule.java 
> PRE-CREATION 
>   src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java 
> 8047622e206c9827e5cd8e40152a278d495bd0ff 
>   src/test/java/org/apache/aurora/scheduler/app/SchedulerIT.java 
> b2ec13f40c12e5ee5663f4465734d6a80f3587cd 
>   
> src/test/java/org/apache/aurora/scheduler/app/local/simulator/ClusterSimulatorModule.java
>  4af49d5dcb1925c4055f5ada8601f6fcab5d7d00 
>   src/test/java/org/apache/aurora/scheduler/async/AsyncModuleTest.java 
> d0faf13e3f1e14b6e70d230fea0fb484f2105873 
>   src/test/java/org/apache/aurora/scheduler/events/PubsubEventModuleTest.java 
> cb38c3e047efac483445f43b941c7eea8862cc9c 
>   src/test/java/org/apache/aurora/scheduler/http/JettyServerModuleTest.java 
> ed8e8119ac3dc41c18316a1ca6e34c178916b09d 
>   
> src/test/java/org/apache/aurora/scheduler/preemptor/PreemptorModuleTest.java 
> 3f045ff38d672266ce2e2bb26f729b0ca4657e81 
>   src/test/java/org/apache/aurora/scheduler/reconciliation/KillRetryTest.java 
> 2f8fc10278e291fb28011b86bfa7c83905c6307c 
>   src/test/java/org/apache/aurora/scheduler/sla/SlaModuleTest.java 
> 63716459a4e21aa035b683ad46ef0a31620cfd98 
> 
> Diff: https://reviews.apache.org/r/38014/diff/
> 
> 
> Testing
> -------
> 
> test suite
> ./gradlew run
> end-to-end tests
> 
> 
> Thanks,
> 
> Bill Farner
> 
>

Reply via email to