-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38086/#review98233
-----------------------------------------------------------



test/deb/ubuntu-trusty/Vagrantfile (lines 6 - 12)
<https://reviews.apache.org/r/38086/#comment154537>

    mutli-vm boilerplate isn't needed
    
    Can replace this block with
    
    ```ruby
    config.vm.provider :virtualbox do |vb|
      vb.customize [...]
    end
    config.vm.provision "shell", path: "provision.sh"
    ```



test/deb/ubuntu-trusty/provision.sh (line 9)
<https://reviews.apache.org/r/38086/#comment154538>

    https



test/rpm/centos-7/README.md (line 8)
<https://reviews.apache.org/r/38086/#comment154539>

    https



test/rpm/centos-7/Vagrantfile (lines 6 - 11)
<https://reviews.apache.org/r/38086/#comment154544>

    Drop multi-vm boilerplate



test/rpm/centos-7/provision.sh (lines 3 - 5)
<https://reviews.apache.org/r/38086/#comment154543>

    yum should include these packages when we install the others, can this line 
be omitted?



test/rpm/centos-7/provision.sh (line 7)
<https://reviews.apache.org/r/38086/#comment154540>

    https



test/rpm/centos-7/provision.sh (line 12)
<https://reviews.apache.org/r/38086/#comment154541>

    https


- Kevin Sweeney


On Sept. 2, 2015, 7:59 p.m., Bill Farner wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38086/
> -----------------------------------------------------------
> 
> (Updated Sept. 2, 2015, 7:59 p.m.)
> 
> 
> Review request for Aurora and Kevin Sweeney.
> 
> 
> Repository: aurora-packaging
> 
> 
> Description
> -------
> 
> Add test environments for RPMs and debs.
> 
> 
> Diffs
> -----
> 
>   .gitignore 849ddff3b7ec917b5f4563e9a6d3ea63ea512a70 
>   test/deb/ubuntu-trusty/README.md PRE-CREATION 
>   test/deb/ubuntu-trusty/Vagrantfile PRE-CREATION 
>   test/deb/ubuntu-trusty/provision.sh PRE-CREATION 
>   test/rpm/centos-7/README.md PRE-CREATION 
>   test/rpm/centos-7/Vagrantfile PRE-CREATION 
>   test/rpm/centos-7/provision.sh PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/38086/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Bill Farner
> 
>

Reply via email to