-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38260/#review98422
-----------------------------------------------------------

Ship it!



src/main/python/apache/aurora/executor/bin/thermos_executor_main.py (line 43)
<https://reviews.apache.org/r/38260/#comment154898>

    I think this should go to stderr like logging and other diagnostic 
information. You can do this by adding the `file` parameter to print and 
passing in `sys.stderr`.


- Zameer Manji


On Sept. 10, 2015, 9:30 a.m., Bill Farner wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38260/
> -----------------------------------------------------------
> 
> (Updated Sept. 10, 2015, 9:30 a.m.)
> 
> 
> Review request for Aurora and Steve Niemitz.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> This is especially useful when running docker-based tasks, as there are image 
> dependencies.  See https://issues.apache.org/jira/browse/AURORA-1487 for an 
> example.
> 
> 
> Diffs
> -----
> 
>   src/main/python/apache/aurora/executor/bin/thermos_executor_main.py 
> b3e8bf1e924999306e0b8a1314273b22c51028e7 
> 
> Diff: https://reviews.apache.org/r/38260/diff/
> 
> 
> Testing
> -------
> 
> Produced a useful error in a docker image:
> ```
> Traceback (most recent call last):
>   File 
> "/thermos_executor/apache/aurora/executor/bin/thermos_executor_main.py", line 
> 41, in <module>
>     from mesos.native import MesosExecutorDriver
>   File 
> "/root/.pex/install/mesos.native-0.23.0-py2.7-linux-x86_64.egg.eb60011deb59722e3835f7a7cfc48d14dc3b104a/mesos.native-0.23.0-py2.7-linux-x86_64.egg/mesos/native/__init__.py",
>  line 17, in <module>
>     from ._mesos import MesosExecutorDriverImpl
> ImportError: libcurl-nss.so.4: cannot open shared object file: No such file 
> or directory
> ```
> 
> 
> Thanks,
> 
> Bill Farner
> 
>

Reply via email to