> On Sept. 11, 2015, 11:59 a.m., Joshua Cohen wrote:
> > File Attachment: resources.png - resources.png
> > <https://reviews.apache.org/r/38313/#fcomment79>
> >
> >     Couple of suggestions on this format:
> >     
> >     1) what do you think about moving the unit into the header, rather than 
> > repeating it on every line? E.g.: CPU (cores) | RAM (MiB) | Disk (MiB).
> >     
> >     2) Maybe right align the numeric values?
> >     
> >     Otherwise looks good to me!

Downside with lifting the unit is that people need to do M->GTP conversions on 
their own.


- Bill


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38313/#review98664
-----------------------------------------------------------


On Sept. 11, 2015, 11:55 a.m., Maxim Khutornenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38313/
> -----------------------------------------------------------
> 
> (Updated Sept. 11, 2015, 11:55 a.m.)
> 
> 
> Review request for Aurora, Joshua Cohen and Bill Farner.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Also, rotated resources table for better UX.
> 
> 
> Diffs
> -----
> 
>   src/main/resources/scheduler/assets/js/controllers.js 
> 511f5c3e0c55bc81b3f41ed23109a8f03188c589 
>   src/main/resources/scheduler/assets/role.html 
> d3a4c7dae7f187081c6f0521912dc23f3ec8a871 
> 
> Diff: https://reviews.apache.org/r/38313/diff/
> 
> 
> Testing
> -------
> 
> 
> File Attachments
> ----------------
> 
> resources.png
>   
> https://reviews.apache.org/media/uploaded/files/2015/09/11/763459b0-0c1a-45be-826e-ffaa613cc719__resources.png
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>

Reply via email to