-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38389/
-----------------------------------------------------------

(Updated Sept. 15, 2015, 7:56 p.m.)


Review request for Aurora, Kevin Sweeney and Bill Farner.


Bugs: AURORA-1485
    https://issues.apache.org/jira/browse/AURORA-1485


Repository: aurora


Description
-------

When generating the client api library for go the default containerizer used as 
a hack for AURORA-1185 breaks and causes the client lib to not be generated 
correctly. The default value for the optional field `container = { "mesos": {} 
}` is not necessary as it is defaulted in java code on the api side.

Tracking this down it looks like the default value was a last minute addition 
based on some review comments and is not necessary or used anywhere.


Diffs (updated)
-----

  api/src/main/thrift/org/apache/aurora/gen/api.thrift 
24a2ca8cc9a236228fdd8aa61c877319a803c9a6 

Diff: https://reviews.apache.org/r/38389/diff/


Testing
-------

Passes all java/py tests in ./build-support/jenkins/build.sh
Passes all e2e tests in ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh


Thanks,

Jake Farrell

Reply via email to