> On Sept. 16, 2015, 2:54 p.m., Zameer Manji wrote:
> > I'm proposing some changes in this review which I think will greatly 
> > simplify the code.
> 
> Maxim Khutornenko wrote:
>     I agree there are ways to improve this functionality but given this is 
> mostly a restore of the old (and proven) commons code can we move these 
> suggestions into a ticket to follow up after this change lands?

I'm ok with this landing if Joe agrees to follow up with a patch.


- Zameer


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38280/#review99312
-----------------------------------------------------------


On Sept. 16, 2015, 2:53 p.m., Joe Smith wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38280/
> -----------------------------------------------------------
> 
> (Updated Sept. 16, 2015, 2:53 p.m.)
> 
> 
> Review request for Aurora, Maxim Khutornenko and Zameer Manji.
> 
> 
> Bugs: AURORA-1473
>     https://issues.apache.org/jira/browse/AURORA-1473
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Restore build properties within Scheduler vars endpoint and snapshots
> 
> 
> Diffs
> -----
> 
>   api/src/main/thrift/org/apache/aurora/gen/storage.thrift 
> 670ba0850987308370e3c766048ad6ba246d9e29 
>   build-support/generate-build-properties PRE-CREATION 
>   build.gradle 9c78aff101793b25e4c1196c170eaf282f73a9bf 
>   
> commons/src/main/java/org/apache/aurora/common/stats/TimeSeriesRepositoryImpl.java
>  c314a0d51e9377c7fe4371a05d7a9375a47a7bf5 
>   commons/src/main/java/org/apache/aurora/common/util/BuildInfo.java 
> PRE-CREATION 
>   
> commons/src/main/java/org/apache/aurora/common/util/testing/FakeBuildInfo.java
>  PRE-CREATION 
>   
> commons/src/test/java/org/apache/aurora/common/stats/TimeSeriesRepositoryImplTest.java
>  89c134315dfdb4c55447032171ec3be8ec73823d 
>   
> src/main/java/org/apache/aurora/scheduler/storage/backup/TemporaryStorage.java
>  d76596c7422786e58b5a8aa79f324911cfd29b25 
>   
> src/main/java/org/apache/aurora/scheduler/storage/log/SnapshotStoreImpl.java 
> 50838de8708d78fc0bd7ee672b7c7ba02dfcd505 
>   src/test/java/org/apache/aurora/scheduler/storage/backup/RecoveryTest.java 
> cc9c066556385c073962903691c037b0c07cc94c 
>   
> src/test/java/org/apache/aurora/scheduler/storage/log/SnapshotStoreImplTest.java
>  6e032a6cef86e5f408bfc0d853a52c7f898d0db8 
> 
> Diff: https://reviews.apache.org/r/38280/diff/
> 
> 
> Testing
> -------
> 
> `./gradlew build -Pq`
> 
> 
> Thanks,
> 
> Joe Smith
> 
>

Reply via email to