----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37087/#review100667 -----------------------------------------------------------
Ship it! Master (5627611) is green with this patch. ./build-support/jenkins/build.sh I will refresh this build result if you post a review containing "@ReviewBot retry" - Aurora ReviewBot On Sept. 25, 2015, 7:03 p.m., Dan Norris wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/37087/ > ----------------------------------------------------------- > > (Updated Sept. 25, 2015, 7:03 p.m.) > > > Review request for Aurora and Bill Farner. > > > Bugs: AURORA-1396 > https://issues.apache.org/jira/browse/AURORA-1396 > > > Repository: aurora > > > Description > ------- > > Add all Docker options supported by Mesos. > > Specifically, this enables you to pass the following options to a Docker > object: > - Docker networking modes > - Privileged mode > - Force pull images > - Docker port mapptings > > This also updates the ordering in the Docker struct in Thrift to match the > Mesos protobuf message. > > Tickets covered: AURORA-1396, AURORA-1057, AURORA-1095. > > > Diffs > ----- > > api/src/main/thrift/org/apache/aurora/gen/api.thrift > a04e644453bfecde44ec7b51b53f42dc82e90c96 > docs/configuration-reference.md ba0dc864a10726456373c23b508e04dd3b08a3ef > examples/vagrant/upstart/aurora-scheduler.conf > 4033184451f36cb5f0233ea96e3dceaae6741275 > src/main/java/org/apache/aurora/scheduler/base/TaskTestUtil.java > 2cdb2f21202c09b6308e3cfa75d2255699b4c2e5 > src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java > f6ba2c40aea555d3e0ab774218bfe08d7e1c984b > src/main/java/org/apache/aurora/scheduler/storage/db/TaskConfigManager.java > 27f1f33ffc782b3d2a2a9add494c04911659e217 > src/main/java/org/apache/aurora/scheduler/storage/db/TaskConfigMapper.java > ce5b1f4e870a3cf743429e6789e74184ff410bbc > > src/main/java/org/apache/aurora/scheduler/storage/db/typehandlers/DockerNetworkingModeTypeHandler.java > PRE-CREATION > src/main/python/apache/aurora/config/schema/base.py > 398f737bed9ef02ce4a5636896d6587bce26501e > src/main/python/apache/aurora/config/thrift.py > b40a7fdfa63eaf18d9a85f62eec5aa717a7e7d91 > > src/main/resources/org/apache/aurora/scheduler/storage/db/TaskConfigMapper.xml > 4e8966dc29689573a5ee3ba4c29392c3a7d14208 > src/main/resources/org/apache/aurora/scheduler/storage/db/schema.sql > 803960fb551aa324a4737d45593d6eb420817525 > src/main/resources/scheduler/assets/configSummary.html > 1af7511de0e8a143c8ea88377aad756b44e3ac30 > src/main/resources/scheduler/assets/js/services.js > b7699fe91d79f9a8141c8368da91443684b6994b > src/test/java/org/apache/aurora/scheduler/app/local/LocalSchedulerMain.java > 4716b66307bad16ecf29ec977e033e31f090fc9d > > src/test/java/org/apache/aurora/scheduler/configuration/ConfigurationManagerTest.java > c6a4ac58479402dd605c8db6de42065f376c7657 > > src/test/java/org/apache/aurora/scheduler/mesos/MesosTaskFactoryImplTest.java > dddf7952d3f0e508cd736d5fb95e573267708d43 > src/test/python/apache/aurora/config/test_thrift.py > 1bd745964b45b30014cabbef89949ac6221f148b > > Diff: https://reviews.apache.org/r/37087/diff/ > > > Testing > ------- > > Ran build-support/jenkins/build.sh and the e2e tests in Vagrant. > > > Thanks, > > Dan Norris > >