-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39073/#review102332
-----------------------------------------------------------



src/main/python/apache/aurora/client/cli/__init__.py (lines 171 - 172)
<https://reviews.apache.org/r/39073/#comment159940>

    Since this doesn't appear to be a documented SPI currently I don't think we 
should set a precedent by retaining backwards-compatibility here.



src/main/python/apache/aurora/client/cli/__init__.py (lines 255 - 261)
<https://reviews.apache.org/r/39073/#comment159941>

    Please add test coverage and documentation for this functionality. A NEWS 
entry would be good form here as well.


- Kevin Sweeney


On Oct. 6, 2015, 10:29 p.m., Brian Wickman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39073/
> -----------------------------------------------------------
> 
> (Updated Oct. 6, 2015, 10:29 p.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Bill Farner.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Generalize plugin interface for client.
> 
> 1. Renames ConfigurationPlugin to just Plugin, since you can register nouns; 
> aliases the two together
> 2. Adds get_nouns method that allows you to register new top-level commands
> 3. Searches entry_points for plugins registered under 
> apache.aurora.client.cli.plugin
> 
> I have used this to implement a proof-of-concept 'aurora deploy' staged 
> rollout framework as well as basic S3 integration (will publish to 
> github.com/wickman/sacker separately.)
> 
> 
> Diffs
> -----
> 
>   src/main/python/apache/aurora/client/cli/__init__.py 
> c1c54549fd8718275041b54e1e91b070dadc05da 
> 
> Diff: https://reviews.apache.org/r/39073/diff/
> 
> 
> Testing
> -------
> 
> Used it to create a sacker plugin for aurora client.
> 
> 
> Thanks,
> 
> Brian Wickman
> 
>

Reply via email to