----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39525/#review103477 -----------------------------------------------------------
Master (5609fc2) is red with this patch. ./build-support/jenkins/build.sh :processJmhResources UP-TO-DATE :jmhClasses :checkstyleJmh :jsHint :checkstyleMain :compileTestJavaNote: Some input files use or override a deprecated API. Note: Recompile with -Xlint:deprecation for details. :processTestResources :testClasses :checkstyleTest :findbugsJmh :findbugsMain :findbugsTest :licenseJmh UP-TO-DATE :licenseMain UP-TO-DATE :licenseTest UP-TO-DATE :license UP-TO-DATE :pmdMain :test :jacocoTestReport Coverage report generated: file:///home/jenkins/jenkins-slave/workspace/AuroraBot/dist/reports/jacoco/test/html/index.html :analyzeReport Instruction coverage is 0.8873498583862232, but must be greater than 0.89 Branch coverage is 0.8132474701011959, but must be greater than 0.835 :analyzeReport FAILED FAILURE: Build failed with an exception. * What went wrong: Execution failed for task ':analyzeReport'. > Test coverage missing for > org/apache/aurora/scheduler/http/api/GsonMessageBodyHandler$2 * Try: Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. BUILD FAILED Total time: 5 mins 17.366 secs I will refresh this build result if you post a review containing "@ReviewBot retry" - Aurora ReviewBot On Oct. 21, 2015, 8:56 p.m., Kevin Sweeney wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39525/ > ----------------------------------------------------------- > > (Updated Oct. 21, 2015, 8:56 p.m.) > > > Review request for Aurora, Maxim Khutornenko and Zameer Manji. > > > Repository: aurora > > > Description > ------- > > This change ignores all SessionKeys. Since the scheduler was doing > "requireNonNull" on SessionKey before the client needs to continue to set > SessionKey to a non-null value for this release. In the next release the > parameter can be dropped completely. > > Apologies for the large diff, thankfully it's mostly red. Coverage in > SchedulerThriftInterface is very high, most of the deleted tests deal with > branches related to authentication or authorization failures, as these are > now enforced in a different layer. > > > Diffs > ----- > > NEWS 7622f9db706c1764876f4174855343414dc59366 > src/main/java/org/apache/aurora/auth/CapabilityValidator.java > 198cdf3a63195c6b125d6a2e5d726075fd41f809 > src/main/java/org/apache/aurora/auth/SessionValidator.java > b688a0f0f1a4549dc4fe81f5cc50af1167856e87 > src/main/java/org/apache/aurora/auth/UnsecureAuthModule.java > 476dd9a89ce317e3bd242fd70a55cc919aff8418 > src/main/java/org/apache/aurora/auth/UnsecureSessionContext.java > 47f81aa4851c753779918dfeb137041073127cd4 > src/main/java/org/apache/aurora/scheduler/app/MoreModules.java > b79ccc849834c9a7f7ac654e4302f2ba4e13ff66 > src/main/java/org/apache/aurora/scheduler/http/JettyServerModule.java > ee024a34f1fdde49791ad6573fe5c0ae3953a7c7 > src/main/java/org/apache/aurora/scheduler/thrift/AuditMessages.java > 3a29a628de8f1c1c3ed609b494656ac95db9efcf > > src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java > 304437e95dd1692b65bf5d0a6697ab62127e6833 > src/main/java/org/apache/aurora/scheduler/thrift/aop/AopModule.java > e951f8e55353ff3c8d7d0e86016a2a004137c299 > > src/main/java/org/apache/aurora/scheduler/thrift/aop/LoggingInterceptor.java > d110b21d4193eb37a10ee8ba2eca82d208496c38 > > src/main/java/org/apache/aurora/scheduler/thrift/aop/UserCapabilityInterceptor.java > dd8d272751034ef7daa720e12dd4ed850532da39 > src/main/java/org/apache/aurora/scheduler/thrift/auth/Requires.java > 9b3431899cddfc7f949fc8cb12f6e4739b4989d0 > src/main/java/org/apache/aurora/scheduler/thrift/auth/ThriftAuthModule.java > e1a21f632f2bee5834cbbde9d6902d71b6a090d9 > src/test/java/org/apache/aurora/auth/UnsecureSessionContextTest.java > c3c34656d781bc54282206caf1211d1385fd68c8 > src/test/java/org/apache/aurora/scheduler/http/api/ApiBetaTest.java > 8af7c46e46d2269903118deb2a2a2b61bcc1d8d1 > src/test/java/org/apache/aurora/scheduler/thrift/AuditMessagesTest.java > 0f8748d2981d48236f602778d2c1848b4c572445 > > src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java > f537f7a39496f69953e6d86cb15359fe3a705480 > src/test/java/org/apache/aurora/scheduler/thrift/ThriftIT.java > f06481bd237db0ab84850fe987d6e1fcb194f31b > src/test/java/org/apache/aurora/scheduler/thrift/aop/AopModuleTest.java > b940e82644365fae613d577ba5b8779077f115d4 > > src/test/java/org/apache/aurora/scheduler/thrift/aop/LoggingInterceptorTest.java > 1bb3eae224de287d0ed83534f1c933ddd72298bb > > Diff: https://reviews.apache.org/r/39525/diff/ > > > Testing > ------- > > ./graldew -Pq clean build > > > Thanks, > > Kevin Sweeney > >
