> On Oct. 22, 2015, 6:02 p.m., Maxim Khutornenko wrote:
> > src/main/python/apache/aurora/client/api/scheduler_client.py, lines 313-315
> > <https://reviews.apache.org/r/39563/diff/1/?file=1103486#file1103486line313>
> >
> >     This change suggests we are effectively dropping the support for this 
> > feature. I agree the design is flawed but probably not worth changing it 
> > now in view of REST API refactoring though. 
> >     
> >     How about setting the version info in auth interceptor instead?
> 
> Kevin Sweeney wrote:
>     I plan to follow up with a patch to do that as well (it's slightly more 
> involved) but I see no reason to keep this feature in place.

If you want to remove it I suggest file a ticket and address it separately 
(with proper schema deprecation ticket, NEWS note and etc.).


- Maxim


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39563/#review103622
-----------------------------------------------------------


On Oct. 22, 2015, 9:35 p.m., Kevin Sweeney wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39563/
> -----------------------------------------------------------
> 
> (Updated Oct. 22, 2015, 9:35 p.m.)
> 
> 
> Review request for Aurora, Maxim Khutornenko and Zameer Manji.
> 
> 
> Bugs: AURORA-1522
>     https://issues.apache.org/jira/browse/AURORA-1522
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Ignore serverInfo on the client side.
> 
> The design of this check is flawed - the client has already sent an RPC to 
> the scheduler and received a response for it, meaning the request has already 
> been processed and this check only serves to ignore its results.
> 
> 
> Diffs
> -----
> 
>   src/main/python/apache/aurora/client/api/scheduler_client.py 
> 8e91788d8cb69ef21df6b045cd07f8cb111b95b3 
>   src/test/python/apache/aurora/client/api/test_scheduler_client.py 
> 10e8ebb4a12cc39d296cfde64ed9b01119d0aac3 
> 
> Diff: https://reviews.apache.org/r/39563/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Kevin Sweeney
> 
>

Reply via email to