-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39563/#review103687
-----------------------------------------------------------
Master (2f173c6) is red with this patch.
./build-support/jenkins/build.sh
Using cached twitter.common.process-0.3.0.tar.gz
Collecting twitter.common.log==0.3.0 (from
twitter.common.app==0.3.0->twitter.checkstyle==0.1.0)
Using cached twitter.common.log-0.3.0.tar.gz
Collecting twitter.common.util==0.3.0 (from
twitter.common.app==0.3.0->twitter.checkstyle==0.1.0)
Using cached twitter.common.util-0.3.0.tar.gz
Collecting twitter.common.collections==0.3.0 (from
twitter.common.app==0.3.0->twitter.checkstyle==0.1.0)
Using cached twitter.common.collections-0.3.0.tar.gz
Collecting smmap>=0.8.5 (from
gitdb>=0.5.1->GitPython==0.3.2.RC1->twitter.checkstyle==0.1.0)
Using cached smmap-0.9.0.tar.gz
Collecting twitter.common.string==0.3.0 (from
twitter.common.process==0.3.0->twitter.common.app==0.3.0->twitter.checkstyle==0.1.0)
Using cached twitter.common.string-0.3.0.tar.gz
Collecting twitter.common.options==0.3.0 (from
twitter.common.log==0.3.0->twitter.common.app==0.3.0->twitter.checkstyle==0.1.0)
Using cached twitter.common.options-0.3.0.tar.gz
Collecting twitter.common.dirutil==0.3.0 (from
twitter.common.log==0.3.0->twitter.common.app==0.3.0->twitter.checkstyle==0.1.0)
Using cached twitter.common.dirutil-0.3.0.tar.gz
Collecting twitter.common.contextutil==0.3.0 (from
twitter.common.util==0.3.0->twitter.common.app==0.3.0->twitter.checkstyle==0.1.0)
Using cached twitter.common.contextutil-0.3.0.tar.gz
Collecting twitter.common.lang==0.3.0 (from
twitter.common.collections==0.3.0->twitter.common.app==0.3.0->twitter.checkstyle==0.1.0)
Using cached twitter.common.lang-0.3.0.tar.gz
Installing collected packages: pyflakes, pep8, smmap, gitdb, GitPython,
twitter.common.lang, twitter.common.string, twitter.common.process,
twitter.common.options, twitter.common.dirutil, twitter.common.log,
twitter.common.contextutil, twitter.common.util, twitter.common.collections,
twitter.common.app, twitter.checkstyle
Running setup.py install for pyflakes
Running setup.py install for pep8
Running setup.py install for smmap
Running setup.py install for gitdb
Running setup.py install for GitPython
Running setup.py install for twitter.common.lang
Running setup.py install for twitter.common.string
Running setup.py install for twitter.common.process
Running setup.py install for twitter.common.options
Running setup.py install for twitter.common.dirutil
Running setup.py install for twitter.common.log
Running setup.py install for twitter.common.contextutil
Running setup.py install for twitter.common.util
Running setup.py install for twitter.common.collections
Running setup.py install for twitter.common.app
Running setup.py install for twitter.checkstyle
Successfully installed GitPython-0.3.2rc1 gitdb-0.6.4 pep8-1.4.5 pyflakes-0.7.2
smmap-0.9.0 twitter.checkstyle-0.1.0 twitter.common.app-0.3.0
twitter.common.collections-0.3.0 twitter.common.contextutil-0.3.0
twitter.common.dirutil-0.3.0 twitter.common.lang-0.3.0 twitter.common.log-0.3.0
twitter.common.options-0.3.0 twitter.common.process-0.3.0
twitter.common.string-0.3.0 twitter.common.util-0.3.0
F821:ERROR src/main/python/apache/aurora/client/api/scheduler_client.py:290
undefined name 'SessionKey'
| auth_args = () if hasattr(ReadOnlyScheduler.Iface, method_name)
else (SessionKey(),)
I will refresh this build result if you post a review containing "@ReviewBot
retry"
- Aurora ReviewBot
On Oct. 22, 2015, 11:27 p.m., Kevin Sweeney wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39563/
> -----------------------------------------------------------
>
> (Updated Oct. 22, 2015, 11:27 p.m.)
>
>
> Review request for Aurora, Maxim Khutornenko and Zameer Manji.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Ignore serverInfo on the client side.
>
> The design of this check is flawed - the client has already sent an RPC to
> the scheduler and received a response for it, meaning the request has already
> been processed and this check only serves to ignore its results.
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/client/api/scheduler_client.py
> 7aa061917c40903bd2f2582a4e928cdfbea81273
> src/test/python/apache/aurora/client/api/test_scheduler_client.py
> 60d222f49e594fd7e5363da445fc57ddf8dc4aba
>
> Diff: https://reviews.apache.org/r/39563/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Kevin Sweeney
>
>
