----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39670/#review104114 -----------------------------------------------------------
src/main/java/org/apache/aurora/scheduler/preemptor/PendingTaskProcessor.java (line 124) <https://reviews.apache.org/r/39670/#comment162351> My money is on this being the problem. The stack trace in the ticket lines up better too. src/main/java/org/apache/aurora/scheduler/preemptor/PendingTaskProcessor.java (line 133) <https://reviews.apache.org/r/39670/#comment162353> AFAICT this was not the issue, since `getOffers()` is backed by `ConcurrentSkipListSet` whose iterators don't throw `ConcurrentModificationException` [1]. [1] http://docs.oracle.com/javase/8/docs/api/java/util/concurrent/package-summary.html#Weakly - Bill Farner On Oct. 26, 2015, 4:16 p.m., Zameer Manji wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39670/ > ----------------------------------------------------------- > > (Updated Oct. 26, 2015, 4:16 p.m.) > > > Review request for Aurora, Maxim Khutornenko and Bill Farner. > > > Bugs: AURORA-1510 > https://issues.apache.org/jira/browse/AURORA-1510 > > > Repository: aurora > > > Description > ------- > > The PendingTaskProcessor runs concurrently with MesosSchedulerImpl. > MesosSchedulerImpl adds/removes offfers from OfferManager while > PendingTaskProcessor iterates over the available offers from OfferManager. > Since OfferManager only returns an unmodifiable view of the underlying list > of offers, this causes a `ConcurrentModificationException`. To prevent this > exception, the PendingTaskProcessor takes an immutable copy of the offers > before iterating over the list of available offers. > > > Diffs > ----- > > > src/main/java/org/apache/aurora/scheduler/preemptor/PendingTaskProcessor.java > 506176769e172b7e9f4ba05c486fe6ab550fb5c3 > > Diff: https://reviews.apache.org/r/39670/diff/ > > > Testing > ------- > > ./gradlew build -Pq > > > Thanks, > > Zameer Manji > >
