----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39691/#review104239 -----------------------------------------------------------
Ship it! Master (c20346c) is green with this patch. ./build-support/jenkins/build.sh I will refresh this build result if you post a review containing "@ReviewBot retry" - Aurora ReviewBot On Oct. 27, 2015, 10:33 p.m., Bill Farner wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39691/ > ----------------------------------------------------------- > > (Updated Oct. 27, 2015, 10:33 p.m.) > > > Review request for Aurora and Zameer Manji. > > > Repository: aurora > > > Description > ------- > > This was causing a long stream of log entries like > ``` > I1019 02:22:19.776 THREAD1945 > org.apache.aurora.scheduler.async.TaskHistoryPruner.deleteTasks: Pruning > inactive tasks [] > ``` > > It results from tasks failing the `safeToPrune` predicate. > > > Diffs > ----- > > src/main/java/org/apache/aurora/scheduler/pruning/TaskHistoryPruner.java > 4e37070e64c83fb9f1d9caaab1a828a1852e46d9 > src/test/java/org/apache/aurora/LifecycleShutdownListenerTest.java > PRE-CREATION > > src/test/java/org/apache/aurora/scheduler/pruning/TaskHistoryPrunerTest.java > acd2cd12ac4f1193c7e6148c4a7266f690ecdab2 > > Diff: https://reviews.apache.org/r/39691/diff/ > > > Testing > ------- > > > Thanks, > > Bill Farner > >