-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39854/
-----------------------------------------------------------

Review request for Aurora, Maxim Khutornenko and Bill Farner.


Bugs: AURORA-1533
    https://issues.apache.org/jira/browse/AURORA-1533


Repository: aurora


Description
-------

Retry scheduler connection after unknown failures.

The `with_scheduler` decorator used to guard the connection using a check of 
`self._scheduler_client`. However, `_construct_scheduler` always sets 
`self._scheduler_client` even though the actual thrift client in `self._client` 
could not be created. This rendered the client useless, as it can neither 
dispatch calls to Aurora, nor does it try to re-establish the connection.

Many known classes of connection errors have not been affected by this bug 
because those are explicitly handled in `method_wrapper` with a call to 
`self.invalidate()`.


Diffs
-----

  src/main/python/apache/aurora/client/api/scheduler_client.py 
8ff21bf64c4a2e6678299439af42e9a0eeacbc7e 
  src/test/python/apache/aurora/client/api/test_scheduler_client.py 
1b4ff9cef167de1e4051e6aaa6e4fb6961fd20f1 

Diff: https://reviews.apache.org/r/39854/diff/


Testing
-------

./pants test.pytest --options=-v 
src/test/python/apache/aurora/client/api:scheduler_client


Thanks,

Stephan Erb

Reply via email to